[Bug 1001115] UART, Ethernet and wallclock driver patches for LPC17XX

[Bug 1001115] UART, Ethernet and wallclock driver patches for LPC17XX

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001115

John Dallaway <john@dallaway.org.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ecos-patches@ecos.sourcewar
                   |                            |e.org, john@dallaway.org.uk
          Component|Serial                      |Patches and contributions

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001115] UART, Ethernet and wallclock driver patches for LPC17XX

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001115

Ilija Kocho <ilijak@siva.com.mk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |1001114

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001115] UART, Ethernet and wallclock driver patches for LPC17XX

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001115

--- Comment #3 from Ilija Kocho <ilijak@siva.com.mk> 2011-01-18 13:02:05 GMT ---
(In reply to comment
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001114#c12)

Sorry for jumping into another bug but I think it is for good reason.

> 
> For each affected package, we could optionally change the CDL "display" and
> "description" strings and the zeroth package "alias" string in ecos.db
> (displayed by configtool) to make them more generic. We should not change any
> CDL macro names or the API.

Talking about "description" there is one issue for which I planned to ask for
help but I forgot. It affects:
http://bugs.ecos.sourceware.org/attachment.cgi?id=1079 and
http://bugs.ecos.sourceware.org/attachment.cgi?id=1080

Descriptions for interrupt priority look like this:
description "
            This option selects the interrupt priority for the EMAC interrupts. 
            There are CYGNUM_DEVS_ETH_IRQ_PRIORITY_LEVELS priority levels
            corresponding to the values 0 through 
            CYGNUM_DEVS_ETH_IRQ_PRIORITY_LEVELS-1 decimal, of which the highest
            value is the lowest priority. The reset value of 
            these registers defaults all interrupts to the lowest priority, 
            allowing a single write to elevate the priority of an 
            individual interrupt."

I know that this is less than perfect, but with my limited knowledge of tcl/CDL
I failed to find a way to enforce substitution of
CYGNUM_DEVS_ETH_IRQ_PRIORITY_LEVELS. I tried something like
      "xxx" . CYGNUM_DEVS_ETH_IRQ_PRIORITY_LEVELS . "xxx"
and some other combinations involving braces and brackets.
Hope there is a way to do it.

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001115] UART, Ethernet and wallclock driver patches for LPC17XX

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001115

Sergei Gavrikov <sergei.gavrikov@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sergei.gavrikov@gmail.com

--- Comment #4 from Sergei Gavrikov <sergei.gavrikov@gmail.com> 2011-01-18 18:19:35 GMT ---
> I failed to find a way to enforce substitution of
> CYGNUM_DEVS_ETH_IRQ_PRIORITY_LEVELS. I tried something like
>       "xxx" . CYGNUM_DEVS_ETH_IRQ_PRIORITY_LEVELS . "xxx"
> and some other combinations involving braces and brackets.
> Hope there is a way to do it.

Ilija, AFAIK, there is no way to get a value of any CDL option
out-side the CDL expressions. Well there is get_data() built-in
function, but it is for *CDL expressions* only.

The CDL commands 'display' and 'description' as well expect only 1
text argument, I mean that 'description' is something like this
(rough prototype in Tcl)

  proc description text {
    set etext [eval $text]
    ...
  }

So, we see new etext value in ecos.ecc (configtool).

The below is okay

  set ::max 16
  description "There are [expr {$::max - 1}] levels"

In configtool we'll see  'There are 15 levels."

And this one is not possible to evaluate

  set ::max CYGNUM_DEVS_ETH_IRQ_PRIORITY_LEVELS
  description "There is [expr {$::max - 1}] levels"

because the max's value is just string
"CYGNUM_DEVS_ETH_IRQ_PRIORITY_LEVELS".

And get_data() function is out the scope (i.e. it is useless for
'description' command).

IMO, such a variant is quite enough there

decription "
    This option selects the interrupt priority for the EMAC
    interrupts.  There are a few priority levels corresponding to the
    values 0 through CYGNUM_DEVS_ETH_IRQ_PRIORITY_LEVELS-1, of which
    the highest value is the lowest priority. The reset value of these
    registers defaults all interrupts to the lowest priority, allowing
    a single write to elevate the priority of an individual
    interrupt."

*a few*, *a number* are good substitutions for text descriptions. In any
case user will see what does the number means in ecos.ecc/configtool.

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001115] UART, Ethernet and wallclock driver patches for LPC17XX

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001115

--- Comment #5 from Sergei Gavrikov <sergei.gavrikov@gmail.com> 2011-01-19 05:28:04 GMT ---
>   proc description text {
>     set etext [eval $text]
>     ...
>   }
> 
> So, we see new etext value in ecos.ecc (configtool).

Ups, should correct myself (wrong pseudo-code). That something like
this

   proc description text {
     ...
   }

Look at the 'text' argument as a text or Tcl expression is evaluated
to text.

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001115] UART, Ethernet and wallclock driver patches for LPC17XX

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001115

Ilija Kocho <ilijak@siva.com.mk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #1080|0                           |1
        is obsolete|                            |

--- Comment #6 from Ilija Kocho <ilijak@siva.com.mk> 2011-02-03 15:27:18 GMT ---
Created an attachment (id=1115)
 --> (http://bugs.ecos.sourceware.org/attachment.cgi?id=1115)
Ethernet (uses ld section for buff.)

Ethernet driver now (if used with LPC17XX) uses memory section instead of raw
memory for buffering. This enables linker control over this memory block and
better memory utilization if it is placed in a same section with lwIP buffers.

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001115] UART, Ethernet and wallclock driver patches for LPC17XX

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001115

Ilija Kocho <ilijak@siva.com.mk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #1079|0                           |1
        is obsolete|                            |

--- Comment #7 from Ilija Kocho <ilijak@siva.com.mk> 2011-02-21 18:17:35 GMT ---
Created an attachment (id=1143)
 --> (http://bugs.ecos.sourceware.org/attachment.cgi?id=1143)
UART with CYGPKG_IO_SERIAL_GENERIC_16X5X_XMIT_REQUIRE_PRIME.

Testing of serial driver with disabled hal_diag revealed that LPC17xx UART
requires CYGPKG_IO_SERIAL_GENERIC_16X5X_XMIT_REQUIRE_PRIME. This was previously
hidden by hal_diag intetference.
A requirement in CDL is added that activates
CYGPKG_IO_SERIAL_GENERIC_16X5X_XMIT_REQUIRE_PRIME.

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001115] UART, Ethernet and wallclock driver patches for LPC17XX

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001115

Ilija Kocho <ilijak@siva.com.mk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #1115|0                           |1
        is obsolete|                            |

--- Comment #8 from Ilija Kocho <ilijak@siva.com.mk> 2011-02-21 18:19:20 GMT ---
Created an attachment (id=1144)
 --> (http://bugs.ecos.sourceware.org/attachment.cgi?id=1144)
Ethernet with minor fixes.

Ethernet driver with some formatting fixes.

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001115] UART, Ethernet and wallclock driver patches for LPC17XX

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001115

Sergei Gavrikov <sergei.gavrikov@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #1143|0                           |1
        is obsolete|                            |

--- Comment #9 from Sergei Gavrikov <sergei.gavrikov@gmail.com> 2011-02-27 16:26:06 GMT ---
Created an attachment (id=1152)
 --> (http://bugs.ecos.sourceware.org/attachment.cgi?id=1152)
serial device support for lpc17xx

Minor clean-ups for attachment 1143.

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001115] UART, Ethernet and wallclock driver patches for LPC17XX

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001115

Sergei Gavrikov <sergei.gavrikov@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #1144|0                           |1
        is obsolete|                            |

--- Comment #10 from Sergei Gavrikov <sergei.gavrikov@gmail.com> 2011-02-27 16:28:27 GMT ---
Created an attachment (id=1153)
 --> (http://bugs.ecos.sourceware.org/attachment.cgi?id=1153)
ethernet device support for lpc17xx

Cleaned-up version of attachment 1144.

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001115] UART, Ethernet and wallclock driver patches for LPC17XX

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001115

Sergei Gavrikov <sergei.gavrikov@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #1081|0                           |1
        is obsolete|                            |

--- Comment #11 from Sergei Gavrikov <sergei.gavrikov@gmail.com> 2011-02-27 18:24:49 GMT ---
Created an attachment (id=1154)
 --> (http://bugs.ecos.sourceware.org/attachment.cgi?id=1154)
wallclock device support for lpc17xx

Added ChangeLog entry, a few clean-ups.

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001115] UART, Ethernet and wallclock driver patches for LPC17XX

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001115

--- Comment #12 from Sergei Gavrikov <sergei.gavrikov@gmail.com> 2011-03-13 14:20:58 GMT ---
Hi

(In reply to comment 9)
> Created an attachment (id=1152)
 --> (http://bugs.ecos.sourceware.org/attachment.cgi?id=1152)
> serial device support for lpc17xx
> 
> Minor clean-ups for attachment 1143.

Checked-in.

(In reply to comment 10)
> Created an attachment (id=1153)
 --> (http://bugs.ecos.sourceware.org/attachment.cgi?id=1153)
> ethernet device support for lpc17xx
> 
> Cleaned-up version of attachment 1144.

Checked-in.

(In reply to comment 11)
> Created an attachment (id=1154)
 --> (http://bugs.ecos.sourceware.org/attachment.cgi?id=1154)
> wallclock device support for lpc17xx
> 
> Added ChangeLog entry, a few clean-ups.

Checked-in.

John Dallaway wrote:
> For each affected package, we could optionally change the CDL
> "display" and "description" strings and the zeroth package "alias"
> string in ecos.db (displayed by configtool) to make them more generic.

So, ecos.db has been updated:

(CYGPKG_DEVICES_WALLCLOCK_ARM_LPC2XXX): Fixed alias/description;
(CYGPKG_DEVS_ETH_ARM_LPC2XXX): Ditto.
(CYGPKG_IO_SERIAL_ARM_LPC24XX): Ditto.

Ilija, thanks for your contribution to eCos. John, thank you for
your valuable points and expertise.

Sergei

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001115] UART, Ethernet and wallclock driver patches for LPC17XX

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001115

Sergei Gavrikov <sergei.gavrikov@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |CURRENTRELEASE

--- Comment #13 from Sergei Gavrikov <sergei.gavrikov@gmail.com> 2011-03-13 14:23:59 GMT ---
Marked as RESOLVED.

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001115] UART, Ethernet and wallclock driver patches for LPC17XX

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001115

--- Comment #14 from Ilija Kocho <ilijak@siva.com.mk> 2011-03-13 16:43:56 GMT ---
(In reply to comment #12)

> Ilija, thanks for your contribution to eCos. John, thank you for
> your valuable points and expertise.
> 
> Sergei

Thank you both for your effort and good advices.

Ilija.

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.