From: bugzilla-daemon@bugs.ecos.sourceware.org
To: ecos-patches@ecos.sourceware.org
Subject: [Bug 1001184] Cortex-m arch: hal_intr.h includes var_intr.h too early.
Date: Sun, 03 Apr 2011 22:37:00 -0000 [thread overview]
Message-ID: <20110403223750.655B82F78003@mail.ecoscentric.com> (raw)
In-Reply-To: <bug-1001184-104@http.bugs.ecos.sourceware.org/>
Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001184
--- Comment #3 from Ilija Kocho <ilijak@siva.com.mk> 2011-04-03 23:37:49 BST ---
(In reply to comment #2)
> (In reply on comment #0)
> > Created an attachment (id=1195)
--> (http://bugs.ecos.sourceware.org/attachment.cgi?id=1195) [details]
> > Include var_intr.h after definition of hal_intr.h macros but allows
> > overriding of CYGNUM_HAL_INTERRUPT_RTC.
> >
> > In Cortex-M architecture, the header hal_intr.h includes var_intr.h
> > twice. Second one is of course with no effect, but the first one is
> > too early. Namely some macros that are defined in hal_intr.h, such as
> > CYGNUM_HAL_INTERRUPT_EXTERNAL, are used in hal-intr.h. This doesn't
> > seem to show ill effect so far since usage is by other macros.
> >
> > Note: The early inclusion of var_intr.h has been introduced by Bug
> > 1001090 Attachment 1092 [details] in order to enable overriding of
> > CYGNUM_HAL_INTERRUPT_RTC by variant/platform.
> >
> > The proposed patch includes var_intr.h after definition of hal_intr.h
> > macros but also allows overriding of CYGNUM_HAL_INTERRUPT_RTC.
>
> Thanks for catch. On my look CYGNUM_HAL_INTERRUPT_RTC definition became
> misplaced lines via that request (no header, in fact). So, I would shift
> down the definition and point on this on CL entry. Certainly, the first
> inclusion of the header can be removed safely then.
Thanks for the reply Sergei. As far as I understand you are going to revert
hal_intr.h to state before Attachment 1092 and in addition shift
CYGNUM_HAL_INTERRUPT_RTC definition after inclusion of var_intr.h. Am I right?
It would fit, since var_intr.h shall be included after definition of Cortex-M
system vectors and before CYGNUM_HAL_INTERRUPT_RTC.
--
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
next prev parent reply other threads:[~2011-04-03 22:37 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <bug-1001184-104@http.bugs.ecos.sourceware.org/>
2011-04-03 9:13 ` bugzilla-daemon
2011-04-03 21:03 ` bugzilla-daemon
2011-04-03 22:37 ` bugzilla-daemon [this message]
2011-04-04 5:54 ` bugzilla-daemon
2011-04-04 10:10 ` bugzilla-daemon
2011-04-04 10:24 ` bugzilla-daemon
2011-04-04 12:25 ` bugzilla-daemon
2011-04-04 13:29 ` bugzilla-daemon
2011-04-04 20:50 ` bugzilla-daemon
2011-04-04 20:56 ` bugzilla-daemon
2011-04-04 21:27 ` bugzilla-daemon
2011-04-04 21:28 ` bugzilla-daemon
2011-04-05 16:18 ` bugzilla-daemon
2011-04-05 16:48 ` bugzilla-daemon
2011-04-05 17:02 ` bugzilla-daemon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110403223750.655B82F78003@mail.ecoscentric.com \
--to=bugzilla-daemon@bugs.ecos.sourceware.org \
--cc=ecos-patches@ecos.sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).