[Bug 1001223] Atmel AT25DFxxx SPI flash

[Bug 1001223] Atmel AT25DFxxx SPI flash

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001223

Christophe Coutand <ecos@hotmail.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ecos-patches@ecos.sourcewar
                   |                            |e.org

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001223] Atmel AT25DFxxx SPI flash

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001223

--- Comment #2 from Christophe Coutand <ecos@hotmail.co.uk> 2011-05-05 18:39:57 BST ---
Created an attachment (id=1224)
 --> (http://bugs.ecos.sourceware.org/attachment.cgi?id=1224)
ecos.db

Added ecos.db

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001223] Atmel AT25DFxxx SPI flash

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001223

Christophe Coutand <ecos@hotmail.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #1223|0                           |1
        is obsolete|                            |

--- Comment #3 from Christophe Coutand <ecos@hotmail.co.uk> 2011-05-21 17:12:52 BST ---
Created an attachment (id=1259)
 --> (http://bugs.ecos.sourceware.org/attachment.cgi?id=1259)
AT25DFxxx source

Updated patch

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001223] Atmel AT25DFxxx SPI flash

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001223

--- Comment #4 from Sergei Gavrikov <sergei.gavrikov@gmail.com> 2011-05-22 20:34:12 BST ---
Hi Christophe,

Thank you for your new FLASH driver(s)!

I have one wish.

I would set value for CYGPKG_DEVS_FLASH_SPI_AT25DFXXX_BLOCK_SIZE in
bytes.  What do you think?  IMO, it is more clear and no need to have
those shift operations in C source.

Ah, two wishes :-)

What is a target that you use with the driver? Is that eCos target? If
it is, could you, please, provide simple test under package's test
directory to give a way to compile the driver? It would be great.  I
mean something like this Chris's test

  devs/flash/spi/m25pxx/current/test/m25pxx_test.c

About the driver's placement, devs/flash/spi is reasonable place on my
look.

Sergei

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001223] Atmel AT25DFxxx SPI flash

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001223

Christophe Coutand <ecos@hotmail.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #1259|0                           |1
        is obsolete|                            |

--- Comment #5 from Christophe Coutand <ecos@hotmail.co.uk> 2011-05-23 18:28:07 BST ---
Created an attachment (id=1263)
 --> (http://bugs.ecos.sourceware.org/attachment.cgi?id=1263)
Updated patch with sector size defined in # of bytes

Hi Sergei,

I have updated the patch to define the sector size in byte. 

The flash is tested with an Actel Smartfusion dev board which is not in CVS. I
have a test case similar to m25pxx_test.c which is located in the dev/flash/ of
the smartfusion board. I'll provide the full BSP when completed.

Christophe

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001223] Atmel AT25DFxxx SPI flash

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001223

Sergei Gavrikov <sergei.gavrikov@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #1263|0                           |1
        is obsolete|                            |

--- Comment #6 from Sergei Gavrikov <sergei.gavrikov@gmail.com> 2011-05-23 21:50:15 BST ---
Created an attachment (id=1265)
 --> (http://bugs.ecos.sourceware.org/attachment.cgi?id=1265)
flash_spi_at25dfxxx: cleaned-up version

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001223] Atmel AT25DFxxx SPI flash

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001223

--- Comment #7 from Sergei Gavrikov <sergei.gavrikov@gmail.com> 2011-05-23 22:08:31 BST ---
(In reply to comment #5)
> I have updated the patch to define the sector size in byte. 

Thank you. I've added a few SZ_*KB definition there (like those in
hal_misc.h) and cleaned-up sources according eCos coding style. See
interdiff for details.

FYI: in CDL 'active_if' value has been fixed. Typo?

Hope that I've broken nothing. At least driver compiles itself without
warnings.

> The flash is tested with an Actel Smartfusion dev board which is not
> in CVS. I have a test case similar to m25pxx_test.c which is located
> in the dev/flash/ of the smartfusion board. I'll provide the full BSP
> when completed.

Great. Could you, please, re-test the update patch (attachment 1265)
then?

Sergei

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001223] Atmel AT25DFxxx SPI flash

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001223

--- Comment #8 from Christophe Coutand <ecos@hotmail.co.uk> 2011-05-23 22:24:12 BST ---
Thanks Sergei. I will re-test the patch and let you know. 

The active_if in the CDL file is copied from the CDL file
devs/flash/spi/m25pxx/current/cdl/flash_m25pxx.cdl

Christophe

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001223] Atmel AT25DFxxx SPI flash

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001223

--- Comment #9 from Christophe Coutand <ecos@hotmail.co.uk> 2011-05-24 18:44:01 BST ---
Hi Sergei,

Latest version of the patch is re-tested OK on Actel board.

Regards,
Christophe

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001223] Atmel AT25DFxxx SPI flash

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001223

--- Comment #10 from Sergei Gavrikov <sergei.gavrikov@gmail.com> 2011-05-25 21:34:30 BST ---
(In reply to comment #9)
> Latest version of the patch is re-tested OK on Actel board.
> 

Now checked-in.

Christophe, thank you for your contribution to eCos, also for testing
and patience.

Sergei

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001223] Atmel AT25DFxxx SPI flash

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001223

--- Comment #11 from Christophe Coutand <ecos@hotmail.co.uk> 2011-05-25 22:06:55 BST ---
Thank you for your time Sergei.

Christophe

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001223] Atmel AT25DFxxx SPI flash

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001223

Sergei Gavrikov <sergei.gavrikov@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |CURRENTRELEASE

--- Comment #12 from Sergei Gavrikov <sergei.gavrikov@gmail.com> 2011-06-01 18:05:25 BST ---
Closed.

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.