[Bug 1001235] New: National Semiconductor DP83848 PHY

[Bug 1001235] New: National Semiconductor DP83848 PHY

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001235

           Summary: National Semiconductor DP83848 PHY
           Product: eCos
           Version: CVS
          Platform: All
        OS/Version: All
            Status: UNCONFIRMED
          Severity: minor
          Priority: low
         Component: Patches and contributions
        AssignedTo: unassigned@bugs.ecos.sourceware.org
        ReportedBy: ecos@hotmail.co.uk
                CC: ecos-patches@ecos.sourceware.org
             Class: Advice Request


Created an attachment (id=1239)
 --> (http://bugs.ecos.sourceware.org/attachment.cgi?id=1239)
Added National Semiconductor DP83848 PHY

Added PHY for Actel Smartfusion board.

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001235] National Semiconductor DP83848 PHY

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001235

--- Comment #1 from Sergei Gavrikov <sergei.gavrikov@gmail.com> 2011-07-22 17:54:01 BST ---
(In reply to comment #0)
> Created an attachment (id=1239)
 --> (http://bugs.ecos.sourceware.org/attachment.cgi?id=1239) [details]
> Added National Semiconductor DP83848 PHY

Hi Christophe,

IMHO, we can add only new _eth_phy_dev() entry for DP83848 PHY IDs to
DP83847.c, look at page #6, please:

http://www.national.com/an/AN/AN-1425.pdf

as DP83847 driver follows IEEE standard (registers).

It seemed to me that we could set ``DP8384x`` as *display* string for
CYGHWR_DEVS_ETH_PHY_DP83847 option and add new entry to DP83847.c only.

Well, to rename the option to CYGHWR_DEVS_ETH_PHY_DP8384X it would be
nice, but the option's name is already taken by a few powerpc targets.
However, may be to have a few DP8384x.c sources  and a few CDL options
is prefered then. What others think?

Sergei

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001235] National Semiconductor DP83848 PHY

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001235

--- Comment #2 from Christophe Coutand <ecos@hotmail.co.uk> 2011-07-22 18:34:09 BST ---
Hi Sergei,

I originally did add the new entry in DP83847.c before changing my mind but I
agree the best solution could be to change the display and description string
of the CYGHWR_DEVS_ETH_PHY_DP83847 CDL to include the DP83848.

Christophe

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001235] National Semiconductor DP83848 PHY

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001235

Sergei Gavrikov <sergei.gavrikov@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #1239|0                           |1
        is obsolete|                            |

--- Comment #3 from Sergei Gavrikov <sergei.gavrikov@gmail.com> 2011-07-22 19:30:18 BST ---
Created an attachment (id=1329)
 --> (http://bugs.ecos.sourceware.org/attachment.cgi?id=1329)
New DP83848 PHY; update moab files due CDL renaming

New PHY DP83848C from National Semiconductor. Update `moab` target due renaming
CYGHWR_DEVS_ETH_PHY_DP83847 to CYGHWR_DEVS_ETH_PHY_DP8384X.

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001235] National Semiconductor DP83848 PHY

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001235

--- Comment #4 from Sergei Gavrikov <sergei.gavrikov@gmail.com> 2011-07-22 19:45:58 BST ---
(In reply to comment #2)
> I originally did add the new entry in DP83847.c before changing my
> mind but I agree the best solution could be to change the display and
> description string of the CYGHWR_DEVS_ETH_PHY_DP83847 CDL to include
> the DP83848.

Fortunately, only one target (moab) used CYGHWR_DEVS_ETH_PHY_DP83847,
so, I updated its CDL/ECM files due renaming the option to *_DP8384X,
also PHY's stat() function was renamed to dp8384x_stat and added your
new entry. However I did not renamed DP83847.c.

Christophe, could you, please, test nsdp8384x.patch (attachment 1329)?

Sergei

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001235] National Semiconductor DP83848 PHY

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001235

--- Comment #5 from Christophe Coutand <ecos@hotmail.co.uk> 2011-07-23 12:33:48 BST ---
Hi Sergei,

Your latest patch (nsdp8384x.patch) is re-tested OK with the smarfusion port.

Christophe

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001235] National Semiconductor DP83848 PHY

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001235

--- Comment #6 from Sergei Gavrikov <sergei.gavrikov@gmail.com> 2011-07-23 12:44:56 BST ---
(In reply to comment #5)
> Your latest patch (nsdp8384x.patch) is re-tested OK with the
> smarfusion port.

Christophe, thank you for testing. If no one objects, I will apply it.

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001235] National Semiconductor DP83848 PHY

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001235

--- Comment #7 from Sergei Gavrikov <sergei.gavrikov@gmail.com> 2011-07-23 18:32:50 BST ---
Checked-in.

Christophe, thanks for your contribution to eCos.

Sergei

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.