[Bug 1001526] New: Fix warnings in bsd_tcpip netinet6 files.

[Bug 1001526] New: Fix warnings in bsd_tcpip netinet6 files.

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001526

           Summary: Fix warnings in bsd_tcpip netinet6 files.
           Product: eCos
           Version: CVS
          Platform: All
        OS/Version: Other
            Status: NEW
          Severity: minor
          Priority: low
         Component: Patches and contributions
        AssignedTo: unassigned@bugs.ecos.sourceware.org
        ReportedBy: grant.b.edwards@gmail.com
                CC: ecos-patches@ecos.sourceware.org
             Class: Advice Request


Created an attachment (id=1633)
 --> (http://bugs.ecos.sourceware.org/attachment.cgi?id=1633)
Patch to fix second half of compiler warnings for bsd_tcpip files.

Second half of compiler warning fixes for bsd_tcpip code.  This patch
is for the files under netinet6.

There is one actual bug fix: at line 1915 of ip6_input.c, in the
function ip6_unknown_opt(), there was a line that looked like this:

          if (!in6p->in6p_flags & IN6P_RTHDR)

The compiler issued a warning about that line, and it's obviously
supposed to be

          if (!(in6p->in6p_flags & IN6P_RTHDR))

I've verified that the latter is the way it now reads in upstream
FreeBSD sources, so I've incorporated the "real" fix rather than just
fixing the warning without changing the code behavior.

So, the net result out of all the new compiler warnings generated by
gcc 4.6.2 is that two actual bugs in source code have been found: the
one above (fixed) and the one in the tftp server code (unfixed and
still generating a warning at this point).

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001526] Fix warnings in bsd_tcpip netinet6 files.

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001526

Jonathan Larmour <jifl@ecoscentric.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jifl@ecoscentric.com

--- Comment #1 from Jonathan Larmour <jifl@ecoscentric.com> 2012-03-09 03:46:09 GMT ---
The CYGBLD_ATTRIB_UNUSED should go near the end of the int error in
ip6_mroute.c line (phyint_send), for consistency.

Everything else is fine, especially the fix!

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 1001526] Fix warnings in bsd_tcpip netinet6 files.

[bugzilla-daemon]

Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001526

Grant Edwards <grant.b.edwards@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |NEXTRELEASE

--- Comment #2 from Grant Edwards <grant.b.edwards@gmail.com> 2012-03-09 19:38:29 GMT ---
Comitted changes:

/cvs/ecos/ecos-opt/net/net/bsd_tcpip/current/ChangeLog,v  <--  ChangeLog
new revision: 1.78; previous revision: 1.77

/cvs/ecos/ecos-opt/net/net/bsd_tcpip/current/src/sys/netinet6/icmp6.c,v  <-- 
icmp6.c
new revision: 1.4; previous revision: 1.3

/cvs/ecos/ecos-opt/net/net/bsd_tcpip/current/src/sys/netinet6/in6_ifattach.c,v 
<--  in6_ifattach.c
new revision: 1.4; previous revision: 1.3

/cvs/ecos/ecos-opt/net/net/bsd_tcpip/current/src/sys/netinet6/in6_src.c,v  <-- 
in6_src.c
new revision: 1.3; previous revision: 1.2

/cvs/ecos/ecos-opt/net/net/bsd_tcpip/current/src/sys/netinet6/ip6_input.c,v 
<--  ip6_input.c
new revision: 1.4; previous revision: 1.3

/cvs/ecos/ecos-opt/net/net/bsd_tcpip/current/src/sys/netinet6/ip6_mroute.c,v 
<--  ip6_mroute.c
new revision: 1.4; previous revision: 1.3

/cvs/ecos/ecos-opt/net/net/bsd_tcpip/current/src/sys/netinet6/ip6_output.c,v 
<--  ip6_output.c
new revision: 1.4; previous revision: 1.3

/cvs/ecos/ecos-opt/net/net/bsd_tcpip/current/src/sys/netinet6/nd6.c,v  <-- 
nd6.c
new revision: 1.5; previous revision: 1.4

/cvs/ecos/ecos-opt/net/net/bsd_tcpip/current/src/sys/netinet6/nd6_nbr.c,v  <-- 
nd6_nbr.c
new revision: 1.3; previous revision: 1.2

/cvs/ecos/ecos-opt/net/net/bsd_tcpip/current/src/sys/netinet6/nd6_rtr.c,v  <-- 
nd6_rtr.c
new revision: 1.3; previous revision: 1.2

/cvs/ecos/ecos-opt/net/net/bsd_tcpip/current/src/sys/netinet6/raw_ip6.c,v  <-- 
raw_ip6.c
new revision: 1.3; previous revision: 1.2

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.