Correct redboot hang with uninitialized config.

Correct redboot hang with uninitialized config.

[Kirill Berezin]

[-- Attachment #1: Type: text/plain, Size: 353 bytes --]

Hello,

I suddenly came across possible hang or sigfault condition for redboot 
with no configuration stored in flash.
The current version of dns module has a default initialization of dns 
domain as a pointer to zero.
As a result redboot hangs on boot on mips32 platform. I attached a patch 
with possible solution, I hope it will be helpful.

Kirill.

[-- Attachment #2: redboot_dns_init.diff --]
[-- Type: text/plain, Size: 660 bytes --]

Index: dns.c
===================================================================
RCS file: /cvs/ecos/ecos/packages/redboot/current/src/net/dns.c,v
retrieving revision 1.5
diff -c -r1.5 dns.c
*** dns.c	29 Jan 2009 17:50:04 -0000	1.5
--- dns.c	22 Apr 2010 12:09:32 -0000
***************
*** 76,82 ****
                        dns_domain,
                        ALWAYS_ENABLED, true,
                        CONFIG_STRING,
!                       0
          );
  #endif
  
--- 76,82 ----
                        dns_domain,
                        ALWAYS_ENABLED, true,
                        CONFIG_STRING,
!                       ""
          );
  #endif
  

Re: Correct redboot hang with uninitialized config.

[John Dallaway]

Hi Kirill

Kirill Berezin wrote:

> I suddenly came across possible hang or sigfault condition for redboot
> with no configuration stored in flash.
> The current version of dns module has a default initialization of dns
> domain as a pointer to zero.
> As a result redboot hangs on boot on mips32 platform. I attached a patch
> with possible solution, I hope it will be helpful.

Good catch. Fix checked in.

Thank you

John Dallaway
eCos maintainer