LPC2XXX ADC modification

LPC2XXX ADC modification

[Peter Huszar]

Hi,

I have noticed that the Olimex H2294 board support includes an ADC that is
specific to some versios of LPC2XXX processors.
It only covers models that have individual conversion registers (LPC24XX
and  LPC21XX/LPC22XX with 01 suffix).

I have modified the ADC driver to support all LPC ADC configurations.

Please let me know if this is of any interest to the eCOS maintainers and/or
the eCOS community.

If interested, please let me know how to go about contributing the modified
ADC code and package information.
I have tested the configurations that I am using, but would only do more
generic test if there is interest from the community.

Rgds Peter 

Re: LPC2XXX ADC modification

[John Dallaway]

Hi Peter

Peter Huszar wrote:

> I have noticed that the Olimex H2294 board support includes an ADC that is
> specific to some versios of LPC2XXX processors.
> It only covers models that have individual conversion registers (LPC24XX
> and  LPC21XX/LPC22XX with 01 suffix).
> 
> I have modified the ADC driver to support all LPC ADC configurations.
> 
> Please let me know if this is of any interest to the eCOS maintainers and/or
> the eCOS community.
> 
> If interested, please let me know how to go about contributing the modified
> ADC code and package information.
> I have tested the configurations that I am using, but would only do more
> generic test if there is interest from the community.

Thank you for your interest in contributing your ADC driver changes.

Extended hardware support is always of interest. If the patch is just a
few lines we may be able to accept it without a copyright assignment,
otherwise you will need to complete copyright paperwork as described at:

  http://ecos.sourceware.org/assign.html

Could you post your patch to ecos-patches@ecos.sourceware.org so we can
advise further?

John Dallaway
eCos maintainer

RE: LPC2XXX ADC modification

[John Dallaway]

Hi Peter

Peter Huszar wrote:

> I have attached the source code. Please let me know if
> you cosider it sufficiently modified to warrant
> a copyright assigment. 

Your code will certainly require a copyright assignment. I recommend
that you start the process as soon as possible as it can take some time.

You should be able to generate a patch using something like this from a
bash prompt:

  cd packages/dev/adc/arm/lpc24xx/current
  diff -U5 src/adc_lpc24xx.c src/adc_lpc2xxx.c > adc_lpc2xxx.patch
  diff -U5 cdl/adc_lpc24xx.cdl cdl/adc_lpc2xxx.cdl >> adc_lpc2xxx.patch

Can you post the resulting patch file to the ecos-patches list please?

John Dallaway
eCos maintainer

> -----Original Message-----
> From: John Dallaway [mailto:john@dallaway.org.uk] 
> Sent: Monday, June 28, 2010 11:54 AM
> To: Peter Huszar
> Cc: eCos Patches List
> Subject: Re: LPC2XXX ADC modification
> 
> Hi Peter
> 
> Peter Huszar wrote:
> 
>> I have noticed that the Olimex H2294 board support includes an ADC that is
>> specific to some versios of LPC2XXX processors.
>> It only covers models that have individual conversion registers (LPC24XX
>> and  LPC21XX/LPC22XX with 01 suffix).
>>
>> I have modified the ADC driver to support all LPC ADC configurations.
>>
>> Please let me know if this is of any interest to the eCOS maintainers
>> and/or the eCOS community.
>>
>> If interested, please let me know how to go about contributing the
>> modified ADC code and package information.
>> I have tested the configurations that I am using, but would only do more
>> generic test if there is interest from the community.
> 
> Thank you for your interest in contributing your ADC driver changes.
> 
> Extended hardware support is always of interest. If the patch is just a
> few lines we may be able to accept it without a copyright assignment,
> otherwise you will need to complete copyright paperwork as described at:
> 
>   http://ecos.sourceware.org/assign.html
> 
> Could you post your patch to ecos-patches@ecos.sourceware.org so we can
> advise further?
> 
> John Dallaway
> eCos maintainer