[Bug 1001869] New: Add support for reading CAN hardware error counters

[Bug 1001869] New: Add support for reading CAN hardware error counters

[bugzilla-daemon]

Please do not reply to this email, use the link below.

http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001869

            Bug ID: 1001869
           Summary: Add support for reading CAN hardware error counters
           Product: eCos
           Version: CVS
            Target: All
  Architecture/Host HostOS: Win XP/7
                OS:
            Status: UNCONFIRMED
          Severity: enhancement
          Priority: low
         Component: Patches and contributions
          Assignee: unassigned@bugs.ecos.sourceware.org
          Reporter: uwe_kindler@web.de
                CC: ecos-patches@ecos.sourceware.org

Created attachment 2267
  --> http://bugs.ecos.sourceware.org/attachment.cgi?id=2267&action=edit
CAN error counter reading patch

The attached patch adds support for reading the CAN hardware RX and TX error
counters. All CAN nodes support these hardware error counters and therefore
this features is a common CAN feature for all CAN device drivers. Support for
reading error counters has been implemented for LPC2xxx CAN device driver.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 1001869] Add support for reading CAN hardware error counters

[bugzilla-daemon]

Please do not reply to this email, use the link below.

http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001869

--- Comment #1 from Uwe Kindler <uwe_kindler@web.de> ---
Could someone please apply this patch to eCos CVS?

Thank you, Uwe

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 1001869] Add support for reading CAN hardware error counters

[bugzilla-daemon]

Please do not reply to this email, use the link below.

http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001869

Sergei Gavrikov <sergei.gavrikov@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sergei.gavrikov@gmail.com

--- Comment #2 from Sergei Gavrikov <sergei.gavrikov@gmail.com> ---
Hi Uwe

What I've seen 1) It was mentioned FlexCAN in a comment for can_lpc2xxx.c, C&P?
2) There is a typo in SGML, once it uses CYG_IO_GET_CONFIG_ERR_COUNTERS name
where should be CYG_IO_GET_CONFIG_CAN_ERR_COUNTERS I believe. Right? Tonight I
test documentation build and then submit some cleaned-up version your patch.

Sergei

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 1001869] Add support for reading CAN hardware error counters

[bugzilla-daemon]

Please do not reply to this email, use the link below.

http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001869

--- Comment #3 from Uwe Kindler <uwe_kindler@web.de> ---
1) Yes, C&P
2) CYG_IO_GET_CONFIG_CAN_ERR_COUNTERS is the right name

Thank you Sergei. I almost finished porting of the free CANopen Stack "CANopen
Node" (http://sourceforge.net/projects/canopennode/) to eCos CAN framework and
this port requires reading of error counters.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 1001869] Add support for reading CAN hardware error counters

[bugzilla-daemon]

Please do not reply to this email, use the link below.

http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001869

Sergei Gavrikov <sergei.gavrikov@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #2267|0                           |1
        is obsolete|                            |

--- Comment #4 from Sergei Gavrikov <sergei.gavrikov@gmail.com> ---
Created attachment 2348
  --> http://bugs.ecos.sourceware.org/attachment.cgi?id=2348&action=edit
cleaned-up version of attachment 2267

Find updated version of attachment 2267. If you can, please, re-test.

Inter-diff is tiny: no CRs, no TABs and trailing white spaces, minor
re-formatting. Hope, I break nothing, at least jade processes text.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 1001869] Add support for reading CAN hardware error counters

[bugzilla-daemon]

Please do not reply to this email, use the link below.

http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001869

--- Comment #5 from Uwe Kindler <uwe_kindler@web.de> ---
Looks good. Could not test documentation because I work on a Windows machine
and do not have a working Docbook environment.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 1001869] Add support for reading CAN hardware error counters

[bugzilla-daemon]

Please do not reply to this email, use the link below.

http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001869

--- Comment #6 from Sergei Gavrikov <sergei.gavrikov@gmail.com> ---
(In reply to comment #5)
> Looks good. Could not test documentation because I work on a Windows machine
> and do not have a working Docbook environment.

Yesterday I tested build of documentation, it's ok. So, if you happy with this
version I'll check-in it (tonight).

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 1001869] Add support for reading CAN hardware error counters

[bugzilla-daemon]

Please do not reply to this email, use the link below.

http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001869

--- Comment #7 from Sergei Gavrikov <sergei.gavrikov@gmail.com> ---
Checked-in. Thank you for contribution to eCos!

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 1001869] Add support for reading CAN hardware error counters

[bugzilla-daemon]

Please do not reply to this email, use the link below.

http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001869

Uwe Kindler <uwe_kindler@web.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |NEXTRELEASE

--- Comment #8 from Uwe Kindler <uwe_kindler@web.de> ---
Thank you. The patch is now checked in.

-- 
You are receiving this mail because:
You are on the CC list for the bug.