[Bug 1001901] New: Add CAN support for Olimex olpcl2294 board

[Bug 1001901] New: Add CAN support for Olimex olpcl2294 board

[bugzilla-daemon]

Please do not reply to this email, use the link below.

http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001901

            Bug ID: 1001901
           Summary: Add CAN support for Olimex olpcl2294 board
           Product: eCos
           Version: CVS
            Target: All
  Architecture/Host Other
                OS:
            Status: UNCONFIRMED
          Severity: enhancement
          Priority: low
         Component: Patches and contributions
          Assignee: unassigned@bugs.ecos.sourceware.org
          Reporter: uwe_kindler@web.de
                CC: ecos-patches@ecos.sourceware.org

Created attachment 2359
  --> http://bugs.ecos.sourceware.org/attachment.cgi?id=2359&action=edit
Add CYGPKG_DEVS_CAN_LPC2XXX to olpcl2294 target

The patch adds CAN support for CAN interface 0 to olpcl2294 target

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 1001901] Add CAN support for Olimex olpcl2294 board

[bugzilla-daemon]

Please do not reply to this email, use the link below.

http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001901

--- Comment #1 from Uwe Kindler <uwe_kindler@web.de> ---
Created attachment 2360
  --> http://bugs.ecos.sourceware.org/attachment.cgi?id=2360&action=edit
CYGPKG_HAL_ARM_LPC2XXX_OLPCL2294 implements CYGINT_DEVS_CAN_LPC2XXX_CAN0

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 1001901] Add CAN support for Olimex olpcl2294 board

[bugzilla-daemon]

Please do not reply to this email, use the link below.

http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001901

--- Comment #2 from Sergei Gavrikov <sergei.gavrikov@gmail.com> ---
Hi Uwe,

I tried to compile CAN driver for LPC-L2294-1M (with patches applied):

  % ecosconfig new olpcl2294
  % ecosconfig add can
  ...
  In file included from devs/can/arm/lpc2xxx/current/src/can_lpc2xxx.c:723:0:
  devs/can/arm/lpc2xxx/current/src/can_accfilt_lpc2xxx.c: In function
'lpc2xxx_can_accfilt_simple_rx_all':
  devs/can/arm/lpc2xxx/current/src/can_accfilt_lpc2xxx.c:774:68: error:
'lpc2xxx_global_can_info_t' has no member named 'init_cnt'
  ...
  make[1]: *** [src/can_lpc2xxx.o.d] Error 1
  make: *** [build] Error 2

It looks like that with CYGINT_IO_CAN_CHANNELS == 1, can_lpc2xxx.c
cannot be compiled.

FYI: I get the same error for LPC-E2294 with such a configuration

  # Force CYGINT_IO_CAN_CHANNELS be 1
  cdl_configuration eCos {
      template    default ;
      package CYGPKG_IO_CAN current ;
  };
  cdl_component CYGPKG_DEVS_CAN_LPC2XXX_CAN1 {
      user_value 0
  };
  cdl_component CYGPKG_DEVS_CAN_LPC2XXX_CAN2 {
      user_value 0
  };
  cdl_component CYGPKG_DEVS_CAN_LPC2XXX_CAN3 {
      user_value 0
  };

Therefore, the error was not entered with the patch.  Could you, please,
look on the LPC2XXX CAN code? Thank you.

Sergei

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 1001901] Add CAN support for Olimex olpcl2294 board

[bugzilla-daemon]

Please do not reply to this email, use the link below.

http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001901

--- Comment #3 from Uwe Kindler <uwe_kindler@web.de> ---
Created attachment 2364
  --> http://bugs.ecos.sourceware.org/attachment.cgi?id=2364&action=edit
lpc2xxx CAN driver init counter patch

The following patch fixes a compile issue of the lpc2xxx driver that only
occurs if support for extended 29-bit CAN identifiers is enabled and support
for message filtering is disabled.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 1001901] Add CAN support for Olimex olpcl2294 board

[bugzilla-daemon]

Please do not reply to this email, use the link below.

http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001901

--- Comment #4 from Sergei Gavrikov <sergei.gavrikov@gmail.com> ---
Well done. Now in CVS. Thank you!

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 1001901] Add CAN support for Olimex olpcl2294 board

[bugzilla-daemon]

Please do not reply to this email, use the link below.

http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001901

Sergei Gavrikov <sergei.gavrikov@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |CURRENTRELEASE

--- Comment #5 from Sergei Gavrikov <sergei.gavrikov@gmail.com> ---
Marked as RESOLVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.