[Bug 1001933] New HAL for the M4 core of Freescale Vybrid targets

[bugzilla-daemon@bugs.ecos.sourceware.org]

Please do not reply to this email, use the link below.

http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001933

Ilija Kocho [Илија Кочо] <ilijak@siva.com.mk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |1001397

--- Comment #4 from Ilija Kocho [Илија Кочо] <ilijak@siva.com.mk> ---
Stefan / Jochen

Thank you for your contribution. It would be nice to have Vybrid in our
repository.

I applied your patches to current eCos CVS and got some warnings and conflicts:

   - Wallclock seems to be missing.
   - Some conflicts pointing to I2C and SPI drivers. It seems that your earlier
patch Attachment 2350 from BUG 1001397 fixes I2C conflicts.
Question
  - Is Attachment 2350 up to date or yiu have newer I2C driver version?
  - What about SPI? There should be some patch.
  - What about drivers that show no conflicts: UART, ENET, eDMA, etc? I would
be very happy and proud if they work with Vybrid unmodified but it seeem too
good to be true.

Looking the code:

   - There are a lot of "reg*.h" files in HAL include directory. Devices in
eCos are decoupled from HAL in order to enable usage of device drivers with
different architectures. I know that this philosophy is not perfectly
implemented, but I aim to do best for new packages. It is especially benefit
for Freescale's chips that re-use peripherals on different architectures.

   - Also there are some type-case problems Vybrid_irq_scheme vs
vybrid_irq_scheme that may work under windows but cause errors on case
sensitive Linux

  - I'm glad to see SGML docs, but they seem incomplete and their compilation
raises errors.



The attached diff contains modifications that I did against current CVS. This
removes conflicts but there are still compilation errors.

Summary:

  -Please prepare new patches that shall work against current CVS. Also provide
patches to device drivers where needed. It would be good to split variant anf
platform patches in separate files.
 - Also for devices - separate patches.
 - Update year in copyright messages (2013 or 2014).
 - Cross-check SGML docs.
 - Remove "reg*.h" headers.
 - I have noticed CDL for Compiler selection. It is unnecessary because user
can specify compiler prefix and flags in "Global Build Options". Please remove
it.

Ilija

-- 
You are receiving this mail because:
You are on the CC list for the bug.