* Re: ping: [PATCH 1/2] Add is_executable to Dwfl_Module.
@ 2014-09-18 14:59 Mark Wielaard
0 siblings, 0 replies; 2+ messages in thread
From: Mark Wielaard @ 2014-09-18 14:59 UTC (permalink / raw)
To: elfutils-devel
[-- Attachment #1: Type: text/plain, Size: 329 bytes --]
On Wed, 2014-09-17 at 22:31 +0200, Jan Kratochvil wrote:
> ping, so that the patchset can move forward
BTW. Please feel free to push the already approved patch that actually
does the code change. The cleanup can be done separately (since it
doesn't really change the code, just makes it more readable).
Cheers,
Mark
^ permalink raw reply [flat|nested] 2+ messages in thread
* ping: [PATCH 1/2] Add is_executable to Dwfl_Module.
@ 2014-09-17 20:31 Jan Kratochvil
0 siblings, 0 replies; 2+ messages in thread
From: Jan Kratochvil @ 2014-09-17 20:31 UTC (permalink / raw)
To: elfutils-devel
[-- Attachment #1: Type: text/plain, Size: 404 bytes --]
ping, so that the patchset can move forward
On Thu, 11 Sep 2014 21:00:49 +0200, Jan Kratochvil wrote:
> On Wed, 10 Sep 2014 22:15:42 +0200, Mark Wielaard wrote:
> > So I propose a cleanup like the attached first.
>
> While I find that as an improvement in general IMO on top of your patch the
> changes could be done a bit differently.
>
> Patricularly I at least miss there that 'e_ident'.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-09-18 14:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-09-18 14:59 ping: [PATCH 1/2] Add is_executable to Dwfl_Module Mark Wielaard
-- strict thread matches above, loose matches on Subject: below --
2014-09-17 20:31 Jan Kratochvil
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).