public inbox for elfutils@sourceware.org
 help / color / mirror / Atom feed
* [PATCH 0/2] Tweak addr2line function names
@ 2014-12-10 19:41 Josh Stone
  0 siblings, 0 replies; 2+ messages in thread
From: Josh Stone @ 2014-12-10 19:41 UTC (permalink / raw)
  To: elfutils-devel

[-- Attachment #1: Type: text/plain, Size: 840 bytes --]

As previously discussed, these patches fix the function names for addr2line.
For addr2line -i, it now walks as many scopes as necessary to find the
containing function, instead of assuming it's the next scope.  Also, addr2line
now prefers linkage_name over the plain die name in all cases.

I haven't addressed the srcline sorting yet, but I intend to.

I had also mentioned some redundancy in the way -f prints inlines, compared to
similar info from -i, but I didn't realize that -S and -x are also involved
here.  I've decided to leave that alone for now.

---
 src/ChangeLog                 |  8 +++++++
 src/addr2line.c               | 55 +++++++++++++++++++++++++++----------------
 tests/ChangeLog               |  5 ++++
 tests/run-addr2line-i-test.sh |  4 +++-
 4 files changed, 51 insertions(+), 21 deletions(-)


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH 0/2] Tweak addr2line function names
@ 2014-12-11 19:29 Josh Stone
  0 siblings, 0 replies; 2+ messages in thread
From: Josh Stone @ 2014-12-11 19:29 UTC (permalink / raw)
  To: elfutils-devel

[-- Attachment #1: Type: text/plain, Size: 1016 bytes --]

On 12/10/2014 11:41 AM, Josh Stone wrote:
> As previously discussed, these patches fix the function names for addr2line.
> For addr2line -i, it now walks as many scopes as necessary to find the
> containing function, instead of assuming it's the next scope.  Also, addr2line
> now prefers linkage_name over the plain die name in all cases.
> 
> I haven't addressed the srcline sorting yet, but I intend to.
> 
> I had also mentioned some redundancy in the way -f prints inlines, compared to
> similar info from -i, but I didn't realize that -S and -x are also involved
> here.  I've decided to leave that alone for now.
> 
> ---
>  src/ChangeLog                 |  8 +++++++
>  src/addr2line.c               | 55 +++++++++++++++++++++++++++----------------
>  tests/ChangeLog               |  5 ++++
>  tests/run-addr2line-i-test.sh |  4 +++-
>  4 files changed, 51 insertions(+), 21 deletions(-)
> 

I added Mark's suggestion for DW_TAG_entry_point, and both patches are
now pushed to master.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-12-11 19:29 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-12-10 19:41 [PATCH 0/2] Tweak addr2line function names Josh Stone
2014-12-11 19:29 Josh Stone

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).