public inbox for elfutils@sourceware.org
 help / color / mirror / Atom feed
* [PATCH] Add EXEEXT to gendis
@ 2017-04-20 15:02 Ulf Hermann
  2017-04-27  8:32 ` Mark Wielaard
  0 siblings, 1 reply; 2+ messages in thread
From: Ulf Hermann @ 2017-04-20 15:02 UTC (permalink / raw)
  To: elfutils-devel

Otherwise the build will fail on systems that actually need file
extension for executables.

Signed-off-by: Ulf Hermann <ulf.hermann@qt.io>
---
 libcpu/ChangeLog   | 4 ++++
 libcpu/Makefile.am | 6 +++---
 2 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/libcpu/ChangeLog b/libcpu/ChangeLog
index e59e876..7fe4345 100644
--- a/libcpu/ChangeLog
+++ b/libcpu/ChangeLog
@@ -1,5 +1,9 @@
 2017-04-20  Ulf Hermann  <ulf.hermann@qt.io>
 
+	* Makefile.am: Add EXEEXT to gendis.
+
+2017-04-20  Ulf Hermann  <ulf.hermann@qt.io>
+
 	* i386_parse.y: Eliminate comparison_fn_t.
 
 2016-11-02  Mark Wielaard  <mjw@redhat.com>
diff --git a/libcpu/Makefile.am b/libcpu/Makefile.am
index b98b583..31fc906 100644
--- a/libcpu/Makefile.am
+++ b/libcpu/Makefile.am
@@ -58,10 +58,10 @@ endif
 if MAINTAINER_MODE
 noinst_HEADERS = memory-access.h i386_parse.h i386_data.h
 
-noinst_PROGRAMS = i386_gendis
+noinst_PROGRAMS = i386_gendis$(EXEEXT)
 
-$(srcdir)/%_dis.h: %_defs i386_gendis
-	$(AM_V_GEN)./i386_gendis $< > $@T
+$(srcdir)/%_dis.h: %_defs i386_gendis$(EXEEXT)
+	$(AM_V_GEN)./i386_gendis$(EXEEXT) $< > $@T
 	$(AM_V_at)mv -f $@T $@
 
 else
-- 
2.1.4

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] Add EXEEXT to gendis
  2017-04-20 15:02 [PATCH] Add EXEEXT to gendis Ulf Hermann
@ 2017-04-27  8:32 ` Mark Wielaard
  0 siblings, 0 replies; 2+ messages in thread
From: Mark Wielaard @ 2017-04-27  8:32 UTC (permalink / raw)
  To: Ulf Hermann; +Cc: elfutils-devel

On Thu, 2017-04-20 at 17:02 +0200, Ulf Hermann wrote:
> Otherwise the build will fail on systems that actually need file
> extension for executables.

Thanks, pushed to master.
We seem to add it in other cases. Surprising this seems to be the only
case that got forgotten. I would have expected more issues.

Cheers,

Mark

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-04-26 15:24 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-20 15:02 [PATCH] Add EXEEXT to gendis Ulf Hermann
2017-04-27  8:32 ` Mark Wielaard

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).