From: Mark Wielaard <mark@klomp.org>
To: Yunlian Jiang <yunlian@google.com>
Cc: elfutils-devel@sourceware.org
Subject: Re: [PATCH] libdwfl: Move nested functions in parse_opt to file scope.
Date: Thu, 27 Jul 2017 16:12:00 -0000 [thread overview]
Message-ID: <1501171933.3741.14.camel@klomp.org> (raw)
In-Reply-To: <CAMsPy2vGZM0Drx1QCSH3+K85ByhP_vy1Ky8GgHmyBa0fv+-tZg@mail.gmail.com>
On Thu, 2017-07-27 at 08:42 -0700, Yunlian Jiang via elfutils-devel
wrote:
> * Move nested function 'failure' to file scope to compile with clang.
> * Move nested function 'fail' to file scope to compile with clang.
The patch seems fine but doesn't apply because of whitespace issues
(looks like tab versus space issues?) Could you sent again.
Thanks,
Mark
next prev parent reply other threads:[~2017-07-27 16:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-27 15:42 Yunlian Jiang via elfutils-devel
2017-07-27 16:12 ` Mark Wielaard [this message]
2017-07-27 16:35 ` Yunlian Jiang via elfutils-devel
2017-07-27 17:04 ` Mark Wielaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1501171933.3741.14.camel@klomp.org \
--to=mark@klomp.org \
--cc=elfutils-devel@sourceware.org \
--cc=yunlian@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).