Re: [PATCH] readelf: Print DIE offset in attribute reading error messages.

[Mark Wielaard <mark@klomp.org>]

On Tue, 2017-11-21 at 12:19 -0700, Tom Tromey wrote:
> > > > > > "Mark" == Mark Wielaard <mark@klomp.org> writes:
> 
> Mark> This has been really useful to debug some DWARF format issues, but it
> Mark> could be even more useful. Since we know the attribute name and form
> Mark> (or we would have generated an error earlier) add those to the error
> Mark> message too.
> 
> Thanks for doing this.
> 
> Does dwarflint also report the error that prompted this?

No, because I am actually testing my DWARF5 work and dwarflint doesn't
support DWARF5 yet. (Also dwarflint doesn't build with the GCC8 trunk
branch which I am using atm.) But also yes, in my tests I corrupted a
DWARF4 .debug_ranges section so it couldn't be read and then dwarflint
will yell and scream about attributes that references it. But also no,
because after that it seems to go into a loop and never finishes...
This might just be it finding too many issues with the missing ranges.
It does suppress warnings after finding too many duplicates, and I
haven't had the patience to let it finish.

> I tried dwarflint on my file, but there was a lot of output and I never
> did track down the precise problem, so I wasn't sure...

Yeah, dwarflint seems hyper sensitive :) Patches welcome!

Cheers,

Mark