From: Mark Wielaard <mark@klomp.org>
To: Dima Kogan <dima@secretsauce.net>, elfutils-devel@sourceware.org
Subject: Re: [PATCH] Fix 22546: dwarf_aggregate_size() works with multi-dimensional arrays
Date: Tue, 12 Dec 2017 09:50:00 -0000 [thread overview]
Message-ID: <1513072228.15696.54.camel@klomp.org> (raw)
In-Reply-To: <87r2s04hej.fsf@secretsauce.net>
On Mon, 2017-12-11 at 21:57 -0800, Dima Kogan wrote:
> If we have a multidimensional array of dimensions (a,b,c) the number of elements
> should be a*b*c, but prior to this patch dwarf_aggregate_size() would report
> a+b+c instead.
>
> This patch fixes the bug and adds a test that demonstrates the bug (the test
> fails without the functional part of this patch).
>
> Fixes: https://sourceware.org/bugzilla/show_bug.cgi?id=22546
Thanks. As said in the bug report, this looks good.
Pushed to master.
Cheers,
Mark
prev parent reply other threads:[~2017-12-12 9:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-12 5:58 Dima Kogan
2017-12-12 9:50 ` Mark Wielaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1513072228.15696.54.camel@klomp.org \
--to=mark@klomp.org \
--cc=dima@secretsauce.net \
--cc=elfutils-devel@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).