From: Mark Wielaard <mark@klomp.org>
To: elfutils-devel@sourceware.org
Cc: Nick Clifton <nickc@redhat.com>, Mark Wielaard <mark@klomp.org>
Subject: [PATCH] libebl: Allow SHT_NOTE as relocation target type.
Date: Wed, 21 Feb 2018 15:36:00 -0000 [thread overview]
Message-ID: <1519227364-17006-1-git-send-email-mark@klomp.org> (raw)
eu-elflint uses ebl_check_reloc_target_type to determine whether a section
is a valid relocation target. In Fedora rawhide there are new ELF notes
(annobin) which have relocations against them in ET_REL files. eu-elflint
currently flags these as invalid. It looks like that is not correct.
I cannot find any reason an SHT_NOTE section cannot have relocations
against it. So this patch allows them.
Signed-off-by: Mark Wielaard <mark@klomp.org>
---
libebl/ChangeLog | 5 +++++
libebl/eblcheckreloctargettype.c | 1 +
2 files changed, 6 insertions(+)
diff --git a/libebl/ChangeLog b/libebl/ChangeLog
index 3ecd732..de325ab 100644
--- a/libebl/ChangeLog
+++ b/libebl/ChangeLog
@@ -1,3 +1,8 @@
+2018-02-21 Mark Wielaard <mark@klomp.org>
+
+ * eblcheckreloctargettype.c (ebl_check_reloc_target_type): Accept
+ SHT_NOTE.
+
2018-02-09 Joshua Watt <JPEWhacker@gmail.com>
* eblobjnote.c (ebl_object_note): Use FALLTHROUGH macro instead of
diff --git a/libebl/eblcheckreloctargettype.c b/libebl/eblcheckreloctargettype.c
index e0d57c1..068ad8f 100644
--- a/libebl/eblcheckreloctargettype.c
+++ b/libebl/eblcheckreloctargettype.c
@@ -46,6 +46,7 @@ ebl_check_reloc_target_type (Ebl *ebl, Elf64_Word sh_type)
case SHT_INIT_ARRAY:
case SHT_FINI_ARRAY:
case SHT_PREINIT_ARRAY:
+ case SHT_NOTE:
return true;
default:
--
1.8.3.1
next reply other threads:[~2018-02-21 15:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-21 15:36 Mark Wielaard [this message]
2018-02-22 12:17 ` Mark Wielaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1519227364-17006-1-git-send-email-mark@klomp.org \
--to=mark@klomp.org \
--cc=elfutils-devel@sourceware.org \
--cc=nickc@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).