From: Mark Wielaard <mark@klomp.org>
To: elfutils-devel@sourceware.org
Subject: Re: [PATCH] libdwfl: Handle unwind frame when the return address register isn't set.
Date: Fri, 13 Apr 2018 11:43:00 -0000 [thread overview]
Message-ID: <1523619825.13039.1.camel@klomp.org> (raw)
In-Reply-To: <1523370202-534-1-git-send-email-mark@klomp.org>
On Tue, 2018-04-10 at 16:23 +0200, Mark Wielaard wrote:
> When we have unwound the frame and then cannot set the return address
> we wouldn't set any error. That meant that a dwfl_thread_getframes ()
> call could end in an error, but without any dwfl_errno set, producing
> the "no error" error message.
>
> If we cannot set the return address at the end of unwinding the frame
> that means that either the return address register is bogus (error),
> or that the return address is undefined (end of the call stack).
>
> This fixes the run-backtrace-native-biarch.sh testcase for me on an
> i386 on x86_64 setup with gcc 7.2.1 and glibc 2.17.
Pushed to master.
prev parent reply other threads:[~2018-04-13 11:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-10 14:23 Mark Wielaard
2018-04-13 11:43 ` Mark Wielaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1523619825.13039.1.camel@klomp.org \
--to=mark@klomp.org \
--cc=elfutils-devel@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).