public inbox for elfutils@sourceware.org
 help / color / mirror / Atom feed
From: "Ying Huang" <ying.huang@oss.cipunited.com>
To: "Mark Wielaard" <mark@klomp.org>
Cc: <elfutils-devel@sourceware.org>
Subject: Re: [PATCH v3 1/6] Support Mips architecture
Date: Fri, 29 Mar 2024 15:40:11 +0800	[thread overview]
Message-ID: <1c09b621-201c-4a9b-8bff-e83f04ad51f6@oss.cipunited.com> (raw)
In-Reply-To: <20240329001807.GR9427@gnu.wildebeest.org>

Hi Mark,

Next time I send a patch, I will add ChangeLog entry in commit message and check the added file.

Thanks,

Ying


在 2024/3/29 08:18, Mark Wielaard 写道:
> Hi Ying,
>
> On Tue, Mar 05, 2024 at 05:51:17PM +0800, Ying Huang wrote:
>> From: Ying Huang <ying.huang@oss.cipunited.com>
>>
>> Signed-off-by: Ying Huang <ying.huang@oss.cipunited.com>
>> ---
>>  backends/Makefile.am    |   6 +-
>>  backends/mips_init.c    |  52 ++++
>>  backends/mips_reloc.def |  93 +++++++
>>  backends/mips_symbol.c  |  63 +++++
>>  libebl/eblopenbackend.c |   2 +
>>  libelf/libelfP.h        |   3 +
>>  tests/libelf.h          | 541 ++++++++++++++++++++++++++++++++++++++++
> Note that this adds tests/libelf.h by accident.  I see how that could
> happen, because it should have been in .gitignore.  I posted a patch
> to do that:
> https://inbox.sourceware.org/elfutils-devel/20240328234308.1032110-1-mark@klomp.org/
>
> Besides that the patch looks fine. I did add a ChangeLog entry to the
> commit message. Pushed as attached.
>
> Thanks,
>
> Mark

  reply	other threads:[~2024-03-29  7:40 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-05  9:51 Ying Huang
2024-03-11 10:02 ` Ying Huang
2024-03-22  2:20   ` Ying Huang
2024-03-29  0:18 ` Mark Wielaard
2024-03-29  7:40   ` Ying Huang [this message]
2024-04-03  9:36   ` Ying Huang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1c09b621-201c-4a9b-8bff-e83f04ad51f6@oss.cipunited.com \
    --to=ying.huang@oss.cipunited.com \
    --cc=elfutils-devel@sourceware.org \
    --cc=mark@klomp.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).