Re: [PATCH] tests: Add an explicit -fasynchronous-unwind-tables for deleted-lib.so.

Re: [PATCH] tests: Add an explicit -fasynchronous-unwind-tables for deleted-lib.so.

[Mark Wielaard]

[-- Attachment #1: Type: text/plain, Size: 904 bytes --]

On Sun, Dec 14, 2014 at 04:44:17AM +0100, Jan Kratochvil wrote:
> On Fri, 12 Dec 2014 21:55:31 +0100, Mark Wielaard wrote:
> > Some systems don't add a PT_GNU_EH_FRAME segment by default, but the
> > deleted test depends on it so that it can get at the .eh_frame_hdr table
> > through the phdrs from the remote memory ELF image. Request one explicitly
> > with -fasynchronous-unwind-tables.
> 
> I remember -fasynchronous-unwind-tables was not the default.  But now even
> RHEL-5 gcc behaves for me as if -fasynchronous-unwind-tables was the default.

Some RHEL versions/arches seem to only add -fasynchronous-unwind-tables
when building with rpmbuild, but don't have it as default for gcc proper.
That means all system binaries have it, but hand compiled code might not.
 
> Anyway I agree the option should be there and I forgot about it.

Thanks, pushed to master.

Cheers,

Mark

Re: [PATCH] tests: Add an explicit -fasynchronous-unwind-tables for deleted-lib.so.

[Jan Kratochvil]

[-- Attachment #1: Type: text/plain, Size: 565 bytes --]

On Fri, 12 Dec 2014 21:55:31 +0100, Mark Wielaard wrote:
> Some systems don't add a PT_GNU_EH_FRAME segment by default, but the
> deleted test depends on it so that it can get at the .eh_frame_hdr table
> through the phdrs from the remote memory ELF image. Request one explicitly
> with -fasynchronous-unwind-tables.

I remember -fasynchronous-unwind-tables was not the default.  But now even
RHEL-5 gcc behaves for me as if -fasynchronous-unwind-tables was the default.

Anyway I agree the option should be there and I forgot about it.


Thanks,
Jan

[PATCH] tests: Add an explicit -fasynchronous-unwind-tables for deleted-lib.so.

[Mark Wielaard]

[-- Attachment #1: Type: text/plain, Size: 1315 bytes --]

Some systems don't add a PT_GNU_EH_FRAME segment by default, but the
deleted test depends on it so that it can get at the .eh_frame_hdr table
through the phdrs from the remote memory ELF image. Request one explicitly
with -fasynchronous-unwind-tables.

Signed-off-by: Mark Wielaard <mjw@redhat.com>
---
 tests/ChangeLog   | 5 +++++
 tests/Makefile.am | 2 +-
 2 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/tests/ChangeLog b/tests/ChangeLog
index 9d229c9..51513b8 100644
--- a/tests/ChangeLog
+++ b/tests/ChangeLog
@@ -1,3 +1,8 @@
+2014-12-12  Mark Wielaard  <mjw@redhat.com>
+
+	* Makefile.am (deleted_lib_so_CFLAGS): Add
+	-fasynchronous-unwind-tables.
+
 2014-12-10  Josh Stone  <jistone@redhat.com>
 
 	* run-addr2line-i-test.sh: Test 0x5f0 to make sure linkage_name is
diff --git a/tests/Makefile.am b/tests/Makefile.am
index 5b38113..ad9baf4 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -414,7 +414,7 @@ debugaltlink_LDADD = $(libdw) $(libelf)
 buildid_LDADD = $(libdw) $(libelf)
 deleted_LDADD = ./deleted-lib.so
 deleted_lib_so_LDFLAGS = -shared -rdynamic
-deleted_lib_so_CFLAGS = -fPIC
+deleted_lib_so_CFLAGS = -fPIC -fasynchronous-unwind-tables
 aggregate_size_LDADD = $(libdw) $(libelf)
 vdsosyms_LDADD = $(libdw) $(libelf)
 
-- 
2.1.0