* [PATCH] Include strings.h to make ffs available
@ 2017-04-20 14:33 Ulf Hermann
2017-04-27 22:23 ` Mark Wielaard
0 siblings, 1 reply; 2+ messages in thread
From: Ulf Hermann @ 2017-04-20 14:33 UTC (permalink / raw)
To: elfutils-devel
We cannot rely on it to be available from any of the other headers.
Signed-off-by: Ulf Hermann <ulf.hermann@qt.io>
---
src/ChangeLog | 4 ++++
src/readelf.c | 1 +
2 files changed, 5 insertions(+)
diff --git a/src/ChangeLog b/src/ChangeLog
index 1521d80..cbb77fc 100644
--- a/src/ChangeLog
+++ b/src/ChangeLog
@@ -1,5 +1,9 @@
2017-04-20 Ulf Hermann <ulf.hermann@qt.io>
+ * readelf.c: Include strings.h.
+
+2017-04-20 Ulf Hermann <ulf.hermann@qt.io>
+
* unstrip.c: Check shnum for 0 before subtracting from it.
2017-04-20 Ulf Hermann <ulf.hermann@qt.io>
diff --git a/src/readelf.c b/src/readelf.c
index 6f6095d..40d4913 100644
--- a/src/readelf.c
+++ b/src/readelf.c
@@ -38,6 +38,7 @@
#include <stdbool.h>
#include <stdlib.h>
#include <string.h>
+#include <strings.h>
#include <time.h>
#include <unistd.h>
#include <sys/stat.h>
--
2.1.4
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] Include strings.h to make ffs available
2017-04-20 14:33 [PATCH] Include strings.h to make ffs available Ulf Hermann
@ 2017-04-27 22:23 ` Mark Wielaard
0 siblings, 0 replies; 2+ messages in thread
From: Mark Wielaard @ 2017-04-27 22:23 UTC (permalink / raw)
To: Ulf Hermann; +Cc: elfutils-devel
On Thu, Apr 20, 2017 at 04:33:28PM +0200, Ulf Hermann wrote:
> We cannot rely on it to be available from any of the other headers.
You are right. I never realized there was both string.h and strings.h.
Applied to master.
Thanks,
Mark
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-04-27 18:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-20 14:33 [PATCH] Include strings.h to make ffs available Ulf Hermann
2017-04-27 22:23 ` Mark Wielaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).