From: Mark Wielaard <mark@klomp.org>
To: Ulf Hermann <ulf.hermann@qt.io>
Cc: elfutils-devel@sourceware.org
Subject: Re: [PATCH v2] Unify linking of libasm, libelf, libdw, backends
Date: Mon, 24 Jul 2017 09:20:00 -0000 [thread overview]
Message-ID: <20170724092003.GA8002@stream> (raw)
In-Reply-To: <90584aa0-6c04-ca62-9994-8b2ede687dc2@qt.io>
On Fri, Feb 17, 2017 at 04:11:28PM +0100, Ulf Hermann wrote:
> Link them all with -z,defs,-z,relro,--no-undefined, provide complete
> dependencies for the link steps, and add libeu.a to each one. libeu.a
> contains useful library functionality that each of them might use. The
> linker will strip unneeded symbols, so linking it in won't hurt even if
> none of the functions are used.
This is a nice cleanup.
Sorry it took so long to review.
Applied to master.
Thanks,
Mark
prev parent reply other threads:[~2017-07-24 9:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-17 15:11 Ulf Hermann
2017-07-24 9:20 ` Mark Wielaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170724092003.GA8002@stream \
--to=mark@klomp.org \
--cc=elfutils-devel@sourceware.org \
--cc=ulf.hermann@qt.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).