public inbox for elfutils@sourceware.org
 help / color / mirror / Atom feed
From: Namhyung Kim <namhyung@gmail.com>
To: elfutils-devel@sourceware.org
Subject: [PATCH] config: Add pkgincludedir to Cflags
Date: Fri, 08 Dec 2017 06:20:00 -0000	[thread overview]
Message-ID: <20171208061738.25974-1-namhyung@gmail.com> (raw)

The libelf and libdw uses pkginclude_HEADERS but the pkg-config file
misses to have it the Cflags.  This was a problem for libdw users since
it gave nothing to include, but one needs to add /usr/include/elfutils
directory to use the libdw.h header file.

Signed-off-by: Namhyung Kim <namhyung@gmail.com>
---
 config/ChangeLog    | 4 ++++
 config/libdw.pc.in  | 2 +-
 config/libelf.pc.in | 2 +-
 3 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/config/ChangeLog b/config/ChangeLog
index ae40cc07..be3f87fb 100644
--- a/config/ChangeLog
+++ b/config/ChangeLog
@@ -1,3 +1,7 @@
+2017-12-08  Namhyung Kim  <namhyung@gmail.com>
+	* libelf.pc.in: Add pkgincludedir to Cflags.
+	* libdw.pc.in: Likewise
+
 2017-11-02  Mark Wielaard  <mark@klomp.org>
 
 	* elfutils.spec.in: Config files under /usr/lib/sysctl.d (_sysctldir)
diff --git a/config/libdw.pc.in b/config/libdw.pc.in
index 3fc283db..e2a083e9 100644
--- a/config/libdw.pc.in
+++ b/config/libdw.pc.in
@@ -9,7 +9,7 @@ Version: @VERSION@
 URL: http://elfutils.org/
 
 Libs: -L${libdir} -ldw
-Cflags: -I${includedir}
+Cflags: -I${includedir} -I${includedir}/elfutils
 
 # We need the exact matching elfutils libelf version since internal data
 # structures are used.
diff --git a/config/libelf.pc.in b/config/libelf.pc.in
index 48f3f021..5455577c 100644
--- a/config/libelf.pc.in
+++ b/config/libelf.pc.in
@@ -9,6 +9,6 @@ Version: @VERSION@
 URL: http://elfutils.org/
 
 Libs: -L${libdir} -lelf
-Cflags: -I${includedir}
+Cflags: -I${includedir} -I${includedir}/elfutils
 
 Requires.private: zlib
-- 
2.15.1

             reply	other threads:[~2017-12-08  6:20 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-08  6:20 Namhyung Kim [this message]
2017-12-11 23:13 ` Mark Wielaard
2017-12-12 14:51   ` Namhyung Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171208061738.25974-1-namhyung@gmail.com \
    --to=namhyung@gmail.com \
    --cc=elfutils-devel@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).