From: Mark Wielaard <mark@klomp.org>
To: Namhyung Kim <namhyung@gmail.com>, elfutils-devel@sourceware.org
Subject: Re: [PATCH] config: Add pkgincludedir to Cflags
Date: Mon, 11 Dec 2017 23:13:00 -0000 [thread overview]
Message-ID: <1513033994.15696.50.camel@klomp.org> (raw)
In-Reply-To: <20171208061738.25974-1-namhyung@gmail.com>
On Fri, 2017-12-08 at 15:17 +0900, Namhyung Kim wrote:
> The libelf and libdw uses pkginclude_HEADERS but the pkg-config file
> misses to have it the Cflags. This was a problem for libdw users since
> it gave nothing to include, but one needs to add /usr/include/elfutils
> directory to use the libdw.h header file.
I this really an issue?
libelf has two public headers which are placed in the includedir and so
should be simply included as #include <libelf.h> and #include <gelf.h>.
libdw does indeed put its headers in includdir/elfutils, but as far as
I know everybody includes them using that subdir, so #include
<elfutils/libdw.h> and #include <elfutils/libdwfl.h>, etc.
Wouldn't this change how people include the headers?
Do we want to change it?
Thanks,
Mark
next prev parent reply other threads:[~2017-12-11 23:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-08 6:20 Namhyung Kim
2017-12-11 23:13 ` Mark Wielaard [this message]
2017-12-12 14:51 ` Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1513033994.15696.50.camel@klomp.org \
--to=mark@klomp.org \
--cc=elfutils-devel@sourceware.org \
--cc=namhyung@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).