* [PATCH] Don't include sys/uio.h if we don't need it
@ 2018-07-17 11:40 Ulf Hermann
2018-07-17 17:46 ` Mark Wielaard
0 siblings, 1 reply; 2+ messages in thread
From: Ulf Hermann @ 2018-07-17 11:40 UTC (permalink / raw)
To: elfutils-devel
The PID attaching only works on linux.
Change-Id: I00428a711b64cb490429363ef28a867b1347956e
---
libdwfl/ChangeLog | 4 ++++
libdwfl/linux-pid-attach.c | 2 +-
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/libdwfl/ChangeLog b/libdwfl/ChangeLog
index acb4236..15d7511 100644
--- a/libdwfl/ChangeLog
+++ b/libdwfl/ChangeLog
@@ -1,3 +1,7 @@
+2018-07-17 Ulf Hermann <ulf.hermann@qt.io>
+
+ * linux-pid-attach.c: Include sys/uio.h only on linux.
+
2018-06-04 Mark Wielaard <mark@klomp.org>
* libdwflP.h (__libdwfl_addrsym): Remove function declaration.
diff --git a/libdwfl/linux-pid-attach.c b/libdwfl/linux-pid-attach.c
index 1133db6..f19e9b4 100644
--- a/libdwfl/linux-pid-attach.c
+++ b/libdwfl/linux-pid-attach.c
@@ -34,13 +34,13 @@
#include "libdwflP.h"
#include <sys/types.h>
#include <sys/stat.h>
-#include <sys/uio.h>
#include <fcntl.h>
#include <dirent.h>
#include <unistd.h>
#ifdef __linux__
+#include <sys/uio.h>
#include <sys/ptrace.h>
#include <sys/syscall.h>
#include <sys/wait.h>
--
2.8.1.windows.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] Don't include sys/uio.h if we don't need it
2018-07-17 11:40 [PATCH] Don't include sys/uio.h if we don't need it Ulf Hermann
@ 2018-07-17 17:46 ` Mark Wielaard
0 siblings, 0 replies; 2+ messages in thread
From: Mark Wielaard @ 2018-07-17 17:46 UTC (permalink / raw)
To: Ulf Hermann; +Cc: elfutils-devel
On Tue, Jul 17, 2018 at 01:40:26PM +0200, Ulf Hermann wrote:
>
> The PID attaching only works on linux.
>
> Change-Id: I00428a711b64cb490429363ef28a867b1347956e
Thanks applied to master.
I did remove the Change-Id tag.
And normally we do require a Signed-off-by line.
Cheers,
Mark
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-07-17 17:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-17 11:40 [PATCH] Don't include sys/uio.h if we don't need it Ulf Hermann
2018-07-17 17:46 ` Mark Wielaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).