[PATCH] Skip run-readelf-compressed.sh test if built without bzip2

[PATCH] Skip run-readelf-compressed.sh test if built without bzip2

[Ulf Hermann]

Obviously, we cannot read the compressed ELF file if no bzip2 support is
present.

Signed-off-by: Ulf Hermann <ulf.hermann@qt.io>
---
  tests/run-readelf-compressed.sh | 5 +++++
  1 file changed, 5 insertions(+)

diff --git a/tests/run-readelf-compressed.sh 
b/tests/run-readelf-compressed.sh
index a2a04a2a..861553fe 100755
--- a/tests/run-readelf-compressed.sh
+++ b/tests/run-readelf-compressed.sh
@@ -17,6 +17,11 @@

  . $srcdir/test-subr.sh

+if ! grep -q -F '#define USE_BZLIB' ${abs_top_builddir}/config.h; then
+  echo "elfutils built without bzip2 support"
+  exit 77
+fi
+
  # See run-strip-reloc.sh
  testfiles hello_i386.ko

-- 
2.11.0

Re: [PATCH] Skip run-readelf-compressed.sh test if built without bzip2

[Mark Wielaard]

On Wed, Jan 09, 2019 at 01:30:19PM +0000, Ulf Hermann wrote:
> Obviously, we cannot read the compressed ELF file if no bzip2 support is
> present.

Added a ChangeLog and pushed to master.
Please don't sent patches with base64 encoding.
That make it really hard to apply them with git am.

Thanks,

Mark

Re: [PATCH] Skip run-readelf-compressed.sh test if built without bzip2

[Ulf Hermann]

> Added a ChangeLog and pushed to master.
> Please don't sent patches with base64 encoding.
> That make it really hard to apply them with git am.

Thanks, and sorry. As the message in my "Sent" folder is plain text with 
7bit encoding, it seems that something in between has re-encoded it (or 
that thunderbird is lying to me).

As this is a repeating theme here, it might be a good idea to add an 
option to submit patches in a less fragile way than inline in email. But 
then, maybe that's just my particularly annoying combination of 
thunderbird client and outlook server that keeps messing things up.

br,
Ulf

Re: [PATCH] Skip run-readelf-compressed.sh test if built without bzip2

[Mark Wielaard]

On Mon, 2019-01-14 at 08:27 +0000, Ulf Hermann wrote:
> > Added a ChangeLog and pushed to master.
> > Please don't sent patches with base64 encoding.
> > That make it really hard to apply them with git am.
> 
> Thanks, and sorry. As the message in my "Sent" folder is plain text with 
> 7bit encoding, it seems that something in between has re-encoded it (or 
> that thunderbird is lying to me).
> 
> As this is a repeating theme here, it might be a good idea to add an 
> option to submit patches in a less fragile way than inline in email. But 
> then, maybe that's just my particularly annoying combination of 
> thunderbird client and outlook server that keeps messing things up.

It might just be git am. It does display fine in my mua too, it is just
git am doesn't seem to like the raw message:

https://sourceware.org/cgi-bin/get-raw-msg?listname=elfutils-devel&date=2019-q1&msgid=67ff4de2-fd5a-0ba8-0b5d-173c5619a88b%40qt.io

But please do feel free to post patches as pull requests using git
request-pull -p if you have a public git repo (but please use -p and
also sent the output to the list to make reviewing easier).

Cheers,

Mark

Re: [PATCH] Skip run-readelf-compressed.sh test if built without bzip2

[Frank Ch. Eigler]

Hi -

> It might just be git am. It does display fine in my mua too, it is just
> git am doesn't seem to like the raw message:
> 
> https://sourceware.org/cgi-bin/get-raw-msg?listname=elfutils-devel&date=2019-q1&msgid=67ff4de2-fd5a-0ba8-0b5d-173c5619a88b%40qt.io

That could be because of sourceware's anti-spammer mangling of the
addresses in email headers.  I don't know if this is worth keeping,
but I use this pipeline for applying get-raw-msg? outputs:

   wget -q -O - "$f" | sed '/^From:/s/ at /@/' | sed '/^From:/s/ dot /./g' | git am

- FChE