[PATCH] unstrip: Fix small leak in handle_output_dir_module.

[PATCH] unstrip: Fix small leak in handle_output_dir_module.

[Mark Wielaard]

eu-unstrip might leak a string for each module found when using the -d
option. Make sure to free the output_file name when we are done with the
module.

Signed-off-by: Mark Wielaard <mark@klomp.org>
---
 src/ChangeLog | 4 ++++
 src/unstrip.c | 2 ++
 2 files changed, 6 insertions(+)

diff --git a/src/ChangeLog b/src/ChangeLog
index f0eee7a8..300deb4f 100644
--- a/src/ChangeLog
+++ b/src/ChangeLog
@@ -1,3 +1,7 @@
+2021-04-03  Mark Wielaard  <mark@klomp.org>
+
+	* unstrip.c (handle_output_dir_module): Free output_file when done.
+
 2021-04-03  Mark Wielaard  <mark@klomp.org>
 
 	* ar.c (do_oper_insert): Always close newfd.
diff --git a/src/unstrip.c b/src/unstrip.c
index f7742ebd..e488e810 100644
--- a/src/unstrip.c
+++ b/src/unstrip.c
@@ -2404,6 +2404,8 @@ handle_output_dir_module (const char *output_dir, Dwfl_Module *mod, bool force,
     error (EXIT_FAILURE, 0, _("memory exhausted"));
 
   handle_dwfl_module (output_file, true, force, mod, all, ignore, relocate);
+
+  free (output_file);
 }
 
 
-- 
2.18.4

Re: [PATCH] unstrip: Fix small leak in handle_output_dir_module.

[Mark Wielaard]

On Sat, Apr 03, 2021 at 07:38:07PM +0200, Mark Wielaard wrote:
> eu-unstrip might leak a string for each module found when using the -d
> option. Make sure to free the output_file name when we are done with the
> module.

Pushed.