public inbox for elfutils@sourceware.org
 help / color / mirror / Atom feed
* patch obv: debuginfod speedup
@ 2021-04-15 11:18 Frank Ch. Eigler
  0 siblings, 0 replies; only message in thread
From: Frank Ch. Eigler @ 2021-04-15 11:18 UTC (permalink / raw)
  To: elfutils-devel

Hi -

About to push this little ditty.


commit a448a4d7997b9d7949a0040c4958eb84bf5e8e0f (HEAD -> master)
Author: Frank Ch. Eigler <fche@redhat.com>
Date:   Thu Apr 15 06:29:01 2021 -0400

    debuginfod: only update database stats once per groom
    
    On very large servers, each database-stat counting pass can take tens
    of minutes (!), and doing it twice per groom pass does not seriously
    improve data quality.  Just do it once, after stale data removal &
    basic sqlite vacuum.
    
    Signed-off-by: Frank Ch. Eigler <fche@redhat.com>

diff --git a/debuginfod/ChangeLog b/debuginfod/ChangeLog
index 3bd2ff606aa6..ed2f77cfaece 100644
--- a/debuginfod/ChangeLog
+++ b/debuginfod/ChangeLog
@@ -1,3 +1,7 @@
+2021-04-15  Frank Ch. Eigler <fche@redhat.com>
+
+	* debuginfod.cxx (groom): Only update database stats once.
+
 2021-04-15  Frank Ch. Eigler <fche@redhat.com>
 
 	* debuginfod.cxx (elf_classify): Recognize symtab-only stripped files
diff --git a/debuginfod/debuginfod.cxx b/debuginfod/debuginfod.cxx
index 2d73a136ae5e..50777f1fa193 100644
--- a/debuginfod/debuginfod.cxx
+++ b/debuginfod/debuginfod.cxx
@@ -3100,8 +3100,6 @@ void groom()
   struct timespec ts_start, ts_end;
   clock_gettime (CLOCK_MONOTONIC, &ts_start);
 
-  database_stats_report();
-
   // scan for files that have disappeared
   sqlite_ps files (db, "check old files", "select s.mtime, s.file, f.name from "
                        BUILDIDS "_file_mtime_scanned s, " BUILDIDS "_files f "



- FChE


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2021-04-15 11:18 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-15 11:18 patch obv: debuginfod speedup Frank Ch. Eigler

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).