From: "Frank Ch. Eigler" <fche@redhat.com>
To: Mark Wielaard <mark@klomp.org>
Cc: Noah Sanci <nsanci@redhat.com>, elfutils-devel@sourceware.org
Subject: Re: [Bug debuginfod/28034] %-escape url characters
Date: Tue, 20 Jul 2021 14:13:51 -0400 [thread overview]
Message-ID: <20210720181351.GF3315@redhat.com> (raw)
In-Reply-To: <YPcM03PSfYzbaq6Z@wildebeest.org>
Hi -
> Could you rewrite the commit message to describe what is done in this
> patch?
(Yeah, Noah's commit text on his branch was corrected.)
> [...]
> I note that filename is actually the full path component of the URL so
> includes slashes ('/'). curl_easy_escape seems to convert these to %2F
> (if I am correct). Is this intended?
It's harmless.
> > +Note: the client should %-escape characters in /SOURCE/FILE that are not shown as "unreserved" in section 2.3 of RFC3986.
>
> This is a very long line. Could you break it up?
> Also, maybe just give the information instead of only a reference.
> (The "unreserved" characters are "a"-"z"", "A"-"Z", "0"-"9", "-", ".", "_" and "~")
> Also same question as above. slash ('/') is not an unreserved
> character, should it be encoded?
As we know from the status quo working for a year+, it doesn't matter
for "/". But RFC3986 does not give a character class that corresponds
exactly to what MUST be encoded, so for documentation purposes this
simple SHOULD guidance seems fine.
- FChE
next prev parent reply other threads:[~2021-07-20 18:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-19 14:53 Noah Sanci
2021-07-20 17:50 ` Mark Wielaard
2021-07-20 18:13 ` Frank Ch. Eigler [this message]
2021-07-20 19:08 ` Mark Wielaard
2021-07-21 18:18 ` Noah Sanci
2021-07-21 19:44 ` Noah Sanci
2021-07-22 12:29 ` Mark Wielaard
2021-07-22 12:28 ` Mark Wielaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210720181351.GF3315@redhat.com \
--to=fche@redhat.com \
--cc=elfutils-devel@sourceware.org \
--cc=mark@klomp.org \
--cc=nsanci@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).