From: "Frank Ch. Eigler" <fche@redhat.com>
To: Mark Wielaard <mark@klomp.org>
Cc: elfutils-devel@sourceware.org
Subject: Re: patch: debuginfod ipv4-ipv6 dual-stack
Date: Mon, 4 Apr 2022 13:03:24 -0400 [thread overview]
Message-ID: <20220404170324.GE933@redhat.com> (raw)
In-Reply-To: <998b003028dc3d65339cb6160159d96f31157570.camel@klomp.org>
Hi -
> That IN6_IS_ADDR_V4MAPPED is funny. Is that actually used in practice?
Yeah, actually all the time. On a dual-stack socket, an ipv4 connection
gets an ipv6 peer-address that renders like ::ffff:1.2.3.4.
> Too bad this cannot be merged with conninfo above.
> But this calculates less info.
Yeah.
> > obatched(clog) << "started http server on "
> > - << (d4 != NULL ? "IPv4 " : "")
> > - << (d6 != NULL ? "IPv6 " : "")
> > + << "IPv4 "
> > + << "IPv6 "
> > << "port=" << http_port << endl;
>
> This keeps the log output the same, but I wouldn't mind just removing
> the IPv4 and IPv6 strings.
Yeah, makes sense. OK, will push with that change.
- FChE
prev parent reply other threads:[~2022-04-04 17:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-03 23:49 Frank Ch. Eigler
2022-04-04 16:58 ` Mark Wielaard
2022-04-04 17:03 ` Frank Ch. Eigler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220404170324.GE933@redhat.com \
--to=fche@redhat.com \
--cc=elfutils-devel@sourceware.org \
--cc=mark@klomp.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).