public inbox for elfutils@sourceware.org
 help / color / mirror / Atom feed
From: Mark Wielaard <mark@klomp.org>
To: German Gomez <german.gomez@arm.com>
Cc: elfutils-devel@sourceware.org
Subject: Re: [PATCH 0/4] Add AARCH64 pointer authentication support
Date: Thu, 28 Apr 2022 21:56:49 +0200	[thread overview]
Message-ID: <20220428195649.GF23335@gnu.wildebeest.org> (raw)
In-Reply-To: <20220425140311.95231-1-german.gomez@arm.com>

Hi German,

On Mon, Apr 25, 2022 at 02:03:07PM +0000, German Gomez via Elfutils-devel wrote:
> I've included a set of patches in order to demangle return addresses in
> aarch64 platforms with pointer authentication.
> 
> Besides adding the implementation of the negate_ra_state opcode, there
> is a new function in the libdwfl.h header to feed the PAC masks to the
> library.
> 
> Let me know if there are any concerns with the current version.

Thanks a lot for this. Last time I looked at this didn't have any
means to test this, so I skipped implementing it. How did you test? Do
distributions now enable PAC by default and is there hardware (qemu?)
support?

I haven't been able to look at the actual patches yet. And I am on
vacation this week. But I'll review next week after I am back.

A quick scan shows we need a aarch64 special public function, which
would be slightly ugly imho. I had hoped it could be a variant of the
func_addr_mask. But maybe this is too different to make more generic.

Cheers,

Mark


  parent reply	other threads:[~2022-04-28 19:56 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-25 14:03 German Gomez
2022-04-25 14:03 ` [PATCH 1/4] aarch64: Create definitions for AARCH64_RA_SIGN_STATE register German Gomez
2023-02-23 16:22   ` Mark Wielaard
2022-04-25 14:03 ` [PATCH 2/4] libdw, aarch64: Implement DW_CFA_AARCH64_negate_ra_state CFI instruction German Gomez
2023-02-23 16:27   ` Mark Wielaard
2022-04-25 14:03 ` [PATCH 3/4] libdwfl, aarch64: Demangle return addresses using a PAC mask German Gomez
2022-04-25 14:03 ` [PATCH 4/4] libdwfl, eu-stack, aarch64: Add API for setting AARCH64 " German Gomez
2022-04-28 19:56 ` Mark Wielaard [this message]
2022-05-19 13:30   ` [PATCH 0/4] Add AARCH64 pointer authentication support German Gomez
2022-05-19 14:20     ` German Gomez
2023-02-24  0:17     ` Mark Wielaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220428195649.GF23335@gnu.wildebeest.org \
    --to=mark@klomp.org \
    --cc=elfutils-devel@sourceware.org \
    --cc=german.gomez@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).