public inbox for elfutils@sourceware.org
 help / color / mirror / Atom feed
From: Mark Wielaard <mark@klomp.org>
To: German Gomez <german.gomez@arm.com>, elfutils-devel@sourceware.org
Subject: Re: [PATCH 1/4] aarch64: Create definitions for AARCH64_RA_SIGN_STATE register
Date: Thu, 23 Feb 2023 17:22:52 +0100	[thread overview]
Message-ID: <e8220dc8ef9f579f4b61bd706a73abc91b85989a.camel@klomp.org> (raw)
In-Reply-To: <20220425140311.95231-2-german.gomez@arm.com>

Hi German,

On Mon, 2022-04-25 at 14:03 +0000, German Gomez via Elfutils-devel
wrote:
> This register will be used to indicate whether a return address is
> mangled with a PAC or not, in accordance with the DWARF AARCH64 ABI [1].
> 
> [1] https://github.com/ARM-software/abi-aa/blob/main/aadwarf64/aadwarf64.rst#41dwarf-register-names

This looks good. With one nit:

> diff --git a/libdw/dwarf.h b/libdw/dwarf.h
> index 3ce7f236..f234c411 100644
> --- a/libdw/dwarf.h
> +++ b/libdw/dwarf.h
> @@ -1011,6 +1011,11 @@ enum
>      DW_EH_PE_indirect = 0x80
>    };
>  
> +/* AARCH64 DWARF registers. */
> +enum
> +  {
> +    DW_AARCH64_RA_SIGN_STATE = 34
> +  };
>  
>  /* DWARF XXX.  */
>  #define DW_ADDR_none	0

dwarf.h is a public header. I rather not define this DW constant here.
Especially since it doesn't seem to have common name (binutils-gdb
calls this AARCH64_DWARF_RA_SIGN_STATE, but only defines it in a
private header). Lets move this into cfi.c as private implementation
detail in the next patch.

Thanks,

Mark

  reply	other threads:[~2023-02-23 16:22 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-25 14:03 [PATCH 0/4] Add AARCH64 pointer authentication support German Gomez
2022-04-25 14:03 ` [PATCH 1/4] aarch64: Create definitions for AARCH64_RA_SIGN_STATE register German Gomez
2023-02-23 16:22   ` Mark Wielaard [this message]
2022-04-25 14:03 ` [PATCH 2/4] libdw, aarch64: Implement DW_CFA_AARCH64_negate_ra_state CFI instruction German Gomez
2023-02-23 16:27   ` Mark Wielaard
2022-04-25 14:03 ` [PATCH 3/4] libdwfl, aarch64: Demangle return addresses using a PAC mask German Gomez
2022-04-25 14:03 ` [PATCH 4/4] libdwfl, eu-stack, aarch64: Add API for setting AARCH64 " German Gomez
2022-04-28 19:56 ` [PATCH 0/4] Add AARCH64 pointer authentication support Mark Wielaard
2022-05-19 13:30   ` German Gomez
2022-05-19 14:20     ` German Gomez
2023-02-24  0:17     ` Mark Wielaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e8220dc8ef9f579f4b61bd706a73abc91b85989a.camel@klomp.org \
    --to=mark@klomp.org \
    --cc=elfutils-devel@sourceware.org \
    --cc=german.gomez@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).