* [COMMITTED] debuginfod-client.c: Don't treat 0 as an error code.
@ 2022-11-07 16:32 Aaron Merey
0 siblings, 0 replies; only message in thread
From: Aaron Merey @ 2022-11-07 16:32 UTC (permalink / raw)
To: elfutils-devel; +Cc: Aaron Merey
Replace 'fd > 0' with 'fd >= 0' to avoid treating a possible file
descriptor as an error code.
Signed-off-by: Aaron Merey <amerey@redhat.com>
---
debuginfod/ChangeLog | 5 +++++
debuginfod/debuginfod-client.c | 4 ++--
2 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/debuginfod/ChangeLog b/debuginfod/ChangeLog
index 5678002a..a17bc5ab 100644
--- a/debuginfod/ChangeLog
+++ b/debuginfod/ChangeLog
@@ -1,3 +1,8 @@
+2022-11-07 Aaron Merey <amerey@redhat.com>
+
+ * debuginfod-client.c (debuginfod_find_section): Don't treat 0 as an
+ error code.
+
2022-11-04 Aaron Merey <amerey@redhat.com>
* debuginfod-client.c (debuginfod_find_section): Ensure rc
diff --git a/debuginfod/debuginfod-client.c b/debuginfod/debuginfod-client.c
index 99da05ef..f9f26fd5 100644
--- a/debuginfod/debuginfod-client.c
+++ b/debuginfod/debuginfod-client.c
@@ -1936,7 +1936,7 @@ debuginfod_find_section (debuginfod_client *client,
}
return -ENOENT;
}
- if (fd > 0)
+ if (fd >= 0)
{
rc = extract_section (fd, section, tmp_path, path);
close (fd);
@@ -1948,7 +1948,7 @@ debuginfod_find_section (debuginfod_client *client,
be in the executable. */
fd = debuginfod_find_executable (client, build_id,
build_id_len, &tmp_path);
- if (fd > 0)
+ if (fd >= 0)
{
rc = extract_section (fd, section, tmp_path, path);
close (fd);
--
2.37.3
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2022-11-07 16:32 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-07 16:32 [COMMITTED] debuginfod-client.c: Don't treat 0 as an error code Aaron Merey
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).