Re: [PATCH v3] strip: keep .ctf section in stripped file

[Mark Wielaard <mark@klomp.org>]

Hi Guillermo,

On Thu, Feb 23, 2023 at 12:42:37PM -0600, Guillermo E. Martinez via Elfutils-devel wrote:
> This is the third version of the patch to avoid remove the CTF section in
> stripped files. Changes from v2:
> 
>   - Rebased from master.
> 
> Please let me know your thoughts.
> 
> CTF debug format was designed to be present in stripped files, so
> this section should not be removed, so a new --remove-ctf option
> is added to indicate explicitly that .ctf section will be stripped
> out from binary file.

Since the way to recognize a CTF section is by name ".ctf" does it
really need a new option? eu-strip already has:

    --keep-section=SECTION Keep the named section.  SECTION is an extended
                           wildcard pattern.  May be given more than once.

-R, --remove-section=SECTION   Remove the named section.  SECTION is an
                           extended wildcard pattern.  May be given more than
                           once.  Only non-allocated sections can be
                           removed.

Do you really need a new option? Or could you use an explicit
--keep-section=.ctf and/or --remove-section=.ctf ?

Thanks,

Mark