From: "Frank Ch. Eigler" <fche@redhat.com>
To: lilydjwg <lilydjwg@gmail.com>
Cc: elfutils-devel@sourceware.org
Subject: Re: [PATCH v2 2/2] debuginfod-client.c: Fix x-debuginfod-size counts differently than CURLINFO_SIZE_DOWNLOAD_T
Date: Wed, 29 Mar 2023 15:14:43 -0400 [thread overview]
Message-ID: <20230329191443.GB30778@redhat.com> (raw)
In-Reply-To: <20230329150237.896092-2-lilydjwg@gmail.com>
Hi -
> x-debuginfod-size is the actual file size, but CURLINFO_SIZE_DOWNLOAD_T
> is transferred size, i.e. the gzipped one if gzip is on.
> Let's count written data and use that if and only if x-debuginfod-size
> is used.
Hey, great idea actually tallying up writes in the callback function.
(We need to take care to clear that counter, in case of client object
reuse.) Also, can you think of some reason not to just use that value
at all times, i.e., without any of that "if and only if ..." business?
- FChE
next prev parent reply other threads:[~2023-03-29 19:14 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-29 4:51 [PATCH] debuginfod-client.c: Fix download size not correctly fallbacks to x-debuginfod-size header lilydjwg
2023-03-29 12:28 ` Frank Ch. Eigler
2023-03-29 14:57 ` lilydjwg
2023-03-29 15:02 ` [PATCH v2 1/2] " lilydjwg
2023-03-29 15:02 ` [PATCH v2 2/2] debuginfod-client.c: Fix x-debuginfod-size counts differently than CURLINFO_SIZE_DOWNLOAD_T lilydjwg
2023-03-29 19:14 ` Frank Ch. Eigler [this message]
2023-03-30 3:41 ` lilydjwg
2023-03-30 17:24 ` Frank Ch. Eigler
2023-03-31 4:50 ` lilydjwg
2023-08-29 13:17 ` Mark Wielaard
2023-08-29 18:33 ` PR30809, was " Frank Ch. Eigler
2023-08-29 19:26 ` Mark Wielaard
2023-03-29 20:49 ` [PATCH v2 1/2] debuginfod-client.c: Fix download size not correctly fallbacks to x-debuginfod-size header Frank Ch. Eigler
2023-03-29 15:05 ` [PATCH] " lilydjwg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230329191443.GB30778@redhat.com \
--to=fche@redhat.com \
--cc=elfutils-devel@sourceware.org \
--cc=lilydjwg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).