public inbox for elfutils@sourceware.org
 help / color / mirror / Atom feed
From: Mark Wielaard <mark@klomp.org>
To: "Frank Ch. Eigler" <fche@redhat.com>
Cc: lilydjwg <lilydjwg@gmail.com>, elfutils-devel@sourceware.org
Subject: Re: PR30809, was Re: [PATCH v2 2/2] debuginfod-client.c: Fix x-debuginfod-size counts differently than CURLINFO_SIZE_DOWNLOAD_T
Date: Tue, 29 Aug 2023 21:26:58 +0200	[thread overview]
Message-ID: <20230829192658.GL8061@gnu.wildebeest.org> (raw)
In-Reply-To: <20230829183307.GE24480@redhat.com>

Hi Frank,

On Tue, Aug 29, 2023 at 02:33:07PM -0400, Frank Ch. Eigler wrote:
> commit 3ef3fab0d64c89a52dd6e2ce0d01dd5e713d7b5a
> Author: Frank Ch. Eigler <fche@redhat.com>
> Date:   Tue Aug 29 14:08:04 2023 -0400
> 
>     PR30809: improve debuginfod client progress-callback parameters
>     
>     * debuginfod-client.c (debuginfod_query_server): Use fstat(3)
>       of the file handle being downloaded into as the preferred
>       source of download progress.
>     
>     Tested by hand, as the testsuite doesn't have enough machinery to
>     simulate compressed vs. uncompressed service.  Hand testing with
>     (unmodified) fedora-38 gdb and debuginfod-find shows dramatically
>     improved progress displays: all have quantitative figures when
>     fetching from real (unmodified) upstream servers.
>     
>     Signed-off-by: Frank Ch. Eigler <fche@redhat.com>

Very nice and simple. Looks good.

Thanks,

Mark

  reply	other threads:[~2023-08-29 19:26 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-29  4:51 [PATCH] debuginfod-client.c: Fix download size not correctly fallbacks to x-debuginfod-size header lilydjwg
2023-03-29 12:28 ` Frank Ch. Eigler
2023-03-29 14:57   ` lilydjwg
2023-03-29 15:02     ` [PATCH v2 1/2] " lilydjwg
2023-03-29 15:02       ` [PATCH v2 2/2] debuginfod-client.c: Fix x-debuginfod-size counts differently than CURLINFO_SIZE_DOWNLOAD_T lilydjwg
2023-03-29 19:14         ` Frank Ch. Eigler
2023-03-30  3:41           ` lilydjwg
2023-03-30 17:24             ` Frank Ch. Eigler
2023-03-31  4:50               ` lilydjwg
2023-08-29 13:17                 ` Mark Wielaard
2023-08-29 18:33                   ` PR30809, was " Frank Ch. Eigler
2023-08-29 19:26                     ` Mark Wielaard [this message]
2023-03-29 20:49       ` [PATCH v2 1/2] debuginfod-client.c: Fix download size not correctly fallbacks to x-debuginfod-size header Frank Ch. Eigler
2023-03-29 15:05     ` [PATCH] " lilydjwg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230829192658.GL8061@gnu.wildebeest.org \
    --to=mark@klomp.org \
    --cc=elfutils-devel@sourceware.org \
    --cc=fche@redhat.com \
    --cc=lilydjwg@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).