public inbox for elfutils@sourceware.org
 help / color / mirror / Atom feed
From: "Frank Ch. Eigler" <fche@redhat.com>
To: "Jan Alexander Steffens (heftig)" <heftig@archlinux.org>
Cc: elfutils-devel@sourceware.org
Subject: Re: [PATCH 3/3] debuginfod: When retrieving files from cache, update atime manually
Date: Wed, 29 Mar 2023 16:54:53 -0400	[thread overview]
Message-ID: <20230329205453.GE30778@redhat.com> (raw)
In-Reply-To: <20230324004805.156080-3-heftig@archlinux.org>

Hi -

> The cache cleaning logic requires atime to be correct (strictatime) but
> most users on Linux only have relatime or even noatime.

This is not really correct: relatime is the kernel default and works
fine with the cache.  atime values updated once a day are still plenty
for caches with a multi-day preservation default.

> Attempt to update the atime manually so that the cache works properly.

Has this been observed to work on noatime-mounted filesystems?  It's
at worst harmless so we could merge it, but it's kind of weird.  Do
you know such precedents in other software that consumes atime?

- FChE


  reply	other threads:[~2023-03-29 20:54 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-24  0:48 [PATCH 1/3] debuginfod: Replace futimes with futimens Jan Alexander Steffens (heftig)
2023-03-24  0:48 ` [PATCH 2/3] debuginfod: Don't touch access time of new files Jan Alexander Steffens (heftig)
2023-03-24  0:48 ` [PATCH 3/3] debuginfod: When retrieving files from cache, update atime manually Jan Alexander Steffens (heftig)
2023-03-29 20:54   ` Frank Ch. Eigler [this message]
2023-03-29 21:32     ` Jan Alexander Steffens (heftig)
2023-03-29 20:47 ` [PATCH 1/3] debuginfod: Replace futimes with futimens Frank Ch. Eigler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230329205453.GE30778@redhat.com \
    --to=fche@redhat.com \
    --cc=elfutils-devel@sourceware.org \
    --cc=heftig@archlinux.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).