public inbox for
 help / color / mirror / Atom feed
From: "Jan Alexander Steffens (heftig)" <>
To: "Frank Ch. Eigler" <>
Subject: Re: [PATCH 3/3] debuginfod: When retrieving files from cache, update atime manually
Date: Wed, 29 Mar 2023 23:32:04 +0200	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

[-- Attachment #1: Type: text/plain, Size: 1567 bytes --]

On Wed, Mar 29, 2023 at 10:54 PM Frank Ch. Eigler <> wrote:

> Hi -
> > The cache cleaning logic requires atime to be correct (strictatime) but
> > most users on Linux only have relatime or even noatime.
> This is not really correct: relatime is the kernel default and works
> fine with the cache.  atime values updated once a day are still plenty
> for caches with a multi-day preservation default.

Ah, I didn't know about the one-day threshold. So that means only
noatime is actually affected.

> > Attempt to update the atime manually so that the cache works properly.
> Has this been observed to work on noatime-mounted filesystems?  It's
> at worst harmless so we could merge it, but it's kind of weird.  Do
> you know such precedents in other software that consumes atime?

Yes, I have a noatime-mounted btrfs (because with snapshots, relatime
can cause entire directory trees to get copied-on-write) and with this
patch series the cache seems to work properly. Without it it is pretty
broken, immediately evicting files that were just downloaded.

The only software I know of that uses atime is mutt, although I have
never used it myself. Looking through the source of mutt and neomutt
on GitHub shows that they use the same approach:
(mutt muttlib.c:2204)
(neomutt mutt/file.c:1062)

  reply	other threads:[~2023-03-29 21:32 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-24  0:48 [PATCH 1/3] debuginfod: Replace futimes with futimens Jan Alexander Steffens (heftig)
2023-03-24  0:48 ` [PATCH 2/3] debuginfod: Don't touch access time of new files Jan Alexander Steffens (heftig)
2023-03-24  0:48 ` [PATCH 3/3] debuginfod: When retrieving files from cache, update atime manually Jan Alexander Steffens (heftig)
2023-03-29 20:54   ` Frank Ch. Eigler
2023-03-29 21:32     ` Jan Alexander Steffens (heftig) [this message]
2023-03-29 20:47 ` [PATCH 1/3] debuginfod: Replace futimes with futimens Frank Ch. Eigler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='' \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).