public inbox for elfutils@sourceware.org
 help / color / mirror / Atom feed
From: Mark Wielaard <mark@klomp.org>
To: Youling Tang <tangyouling@loongson.cn>
Cc: elfutils-devel@sourceware.org,
	Hengqi Chen <hengqi.chen@gmail.com>,
	Liwei Ge <geliwei@openanolis.org>
Subject: Re: [PATCH] backends: add checks for _GLOBAL_OFFSET_TABLE_ on loongarch
Date: Fri, 7 Apr 2023 00:52:17 +0200	[thread overview]
Message-ID: <20230406225217.GF18331@gnu.wildebeest.org> (raw)
In-Reply-To: <1680319133-22776-1-git-send-email-tangyouling@loongson.cn>

Hi,

On Sat, Apr 01, 2023 at 11:18:53AM +0800, Youling Tang wrote:
> Add handling of _GLOBAL_OFFSET_TABLE_.
> 
> Before applying the patch:
> $ ./src/elflint --gnu-ld ./src/elflint
> section [35] '.symtab': _GLOBAL_OFFSET_TABLE_ symbol value 0x68548
> does not match .got.plt section address 0x68238
> 
> After applying the patch:
> $ ./src/elflint --gnu-ld ./src/elflint
> No errors

Thanks, code looks correct.  I agree that the other issue mentioned
(_DYNAMIC symbol size 0) is a separate issue.

Pushed,

Mark

      parent reply	other threads:[~2023-04-06 22:52 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-01  3:18 Youling Tang
2023-04-04 15:45 ` Hengqi Chen
2023-04-06  1:59   ` Youling Tang
2023-04-06 22:52 ` Mark Wielaard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230406225217.GF18331@gnu.wildebeest.org \
    --to=mark@klomp.org \
    --cc=elfutils-devel@sourceware.org \
    --cc=geliwei@openanolis.org \
    --cc=hengqi.chen@gmail.com \
    --cc=tangyouling@loongson.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).