* [PATCH] libelf/elf_newscn.c: fix build failure against gcc-14 (-Walloc-size)
@ 2023-11-02 19:58 Sergei Trofimovich
2023-11-02 23:23 ` Mark Wielaard
0 siblings, 1 reply; 2+ messages in thread
From: Sergei Trofimovich @ 2023-11-02 19:58 UTC (permalink / raw)
To: elfutils-devel; +Cc: Sergei Trofimovich
`gcc-14` adde a new -Walloc-size warning that makes sure that size of an
individual element matches size of a pointed type:
https://gcc.gnu.org/PR71219
`elfutils` triggers is on `calloc()` call where member size is sued as
`1`.
elf_newscn.c: In function `elf_newscn`:
elf_newscn.c:97:12: error: allocation of insufficient size «1» for type «Elf_ScnList» with size «16» [-Werror=alloc-size]
97 | newp = calloc (sizeof (Elf_ScnList)
| ^
The change swaps arguments to pass larger value as a member size.
Signed-off-by: Sergei Trofimovich <slyich@gmail.com>
---
libelf/elf_newscn.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/libelf/elf_newscn.c b/libelf/elf_newscn.c
index d6bdf153..ec731f75 100644
--- a/libelf/elf_newscn.c
+++ b/libelf/elf_newscn.c
@@ -94,9 +94,9 @@ elf_newscn (Elf *elf)
1
#endif
)
- newp = calloc (sizeof (Elf_ScnList)
- + ((elf->state.elf.scnincr *= 2)
- * sizeof (Elf_Scn)), 1);
+ newp = calloc (1, sizeof (Elf_ScnList)
+ + ((elf->state.elf.scnincr *= 2)
+ * sizeof (Elf_Scn)));
if (newp == NULL)
{
__libelf_seterrno (ELF_E_NOMEM);
--
2.42.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] libelf/elf_newscn.c: fix build failure against gcc-14 (-Walloc-size)
2023-11-02 19:58 [PATCH] libelf/elf_newscn.c: fix build failure against gcc-14 (-Walloc-size) Sergei Trofimovich
@ 2023-11-02 23:23 ` Mark Wielaard
0 siblings, 0 replies; 2+ messages in thread
From: Mark Wielaard @ 2023-11-02 23:23 UTC (permalink / raw)
To: Sergei Trofimovich; +Cc: elfutils-devel
Hi Sergei,
On Thu, Nov 02, 2023 at 07:58:46PM +0000, Sergei Trofimovich wrote:
> `gcc-14` adde a new -Walloc-size warning that makes sure that size of an
> individual element matches size of a pointed type:
>
> https://gcc.gnu.org/PR71219
>
> `elfutils` triggers is on `calloc()` call where member size is sued as
> `1`.
>
> elf_newscn.c: In function `elf_newscn`:
> elf_newscn.c:97:12: error: allocation of insufficient size «1» for type «Elf_ScnList» with size «16» [-Werror=alloc-size]
> 97 | newp = calloc (sizeof (Elf_ScnList)
> | ^
>
> The change swaps arguments to pass larger value as a member size.
Very nice. Patch applied.
Thanks,
Mark
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-11-02 23:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-11-02 19:58 [PATCH] libelf/elf_newscn.c: fix build failure against gcc-14 (-Walloc-size) Sergei Trofimovich
2023-11-02 23:23 ` Mark Wielaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).