Re: [PATCH] lib: remove usage of `sys/cdefs.h`

[Mark Wielaard <mark@klomp.org>]

Hi Saleem,

On Mon, 2021-08-23 at 08:23 -0700, Saleem Abdulrasool via Elfutils-
devel wrote:
> Yes, it seems that `STROF` can be removed as well.  However, I'd
> prefer to do that in a separate change.  This way the change is a
> separate clean up rather than just happens to come along with the
> sys/cdefs.h removal.

Please do post a followup patch.

I added a ChangeLog entry (yes, we still do those, although it seems
very little people share my enthusiasm for them, so maybe we should
drop them, at least as separate file entries) and pushed your patch as:

commit d390548df1942e98a1d836269a5e41ba52e121f1
Author: Saleem Abdulrasool <abdulras@google.com>
Date:   Fri Aug 20 18:20:08 2021 +0000

    lib: remove usage of `sys/cdefs.h`
    
    This header is a BSD header that is also available in glibc.  However,
    this is a not a standard C header and was used for `__CONCAT`.  Because
    this is not a standard header, not all libc implementations provide the
    header.  Remove the usage of the header and always use the previously
    fallback path.  This is needed in order to build with musl.
    
    Signed-off-by: Saleem Abdulrasool <abdulras@google.com>

Thanks,

Mark

P.S. You might want to use git send-email --from=... to add an extra
From author line. Sadly the mailinglist mangles the original From in
some cases causing git am to apply a patch with the mailinglist as
author (sorry about that).