[PATCH] lib/color: Fix compilation with uClibc

[PATCH] lib/color: Fix compilation with uClibc

[Rosen Penev]

elfutils passed -Werror and this call errors on uClibc with a mismatching
pointer type. Cast to char * to fix.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
 lib/color.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/color.c b/lib/color.c
index 9ffbf55f..20b9698a 100644
--- a/lib/color.c
+++ b/lib/color.c
@@ -132,7 +132,7 @@ valid arguments are:\n\
   - 'auto', 'tty', 'if-tty'\n"),
 		     program_invocation_short_name, arg);
 	      argp_help (&color_argp, stderr, ARGP_HELP_SEE,
-			 program_invocation_short_name);
+			 (char *) program_invocation_short_name);
 	      exit (EXIT_FAILURE);
 	    }
 	}
-- 
2.17.1

Re: [PATCH] lib/color: Fix compilation with uClibc

[Mark Wielaard]

On Fri, 2019-05-03 at 10:59 -0700, Rosen Penev wrote:
> elfutils passed -Werror and this call errors on uClibc with a
> mismatching pointer type. Cast to char * to fix.

Aha. I see uClibc defines program_invocation_short_name as a const
char*, while glibc defines it as a char *. And argp_help takes a char *
name as argument in both. Slightly odd, but sure, the cast to char *
should be harmless.

Added a ChangeLog entry and pushed to master.

Thanks,

Mark