From: "Martin Liška" <mliska@suse.cz>
To: Mark Wielaard <mark@klomp.org>, elfutils-devel@sourceware.org
Subject: Re: [PATCH] libebl: Do not require EI_OSABI for IFUNC.
Date: Fri, 25 Nov 2022 14:06:00 +0100 [thread overview]
Message-ID: <28991dcc-34eb-a6c5-b753-39c24933dded@suse.cz> (raw)
In-Reply-To: <b2c5432e850ecd9550e9cbd2ad6b199ae05a487a.camel@klomp.org>
On 11/24/22 13:33, Mark Wielaard wrote:
> Hi Martin,
>
> On Thu, 2022-11-24 at 13:23 +0100, Martin Liška wrote:
>> Similar fix to:
>> https://sourceware.org/bugzilla/show_bug.cgi?id=29718
>>
>> Ready for master?
>
> Assuming runtime, glibc/ld.so, accepts this without EI_OSABI set to
> ELFOSABI_LINUX, it seems ok to print it as GNU_IFUNC.
>
>> else if (symbol == STT_GNU_IFUNC
>> && ebl != NULL
>> - && (ident = elf_getident (ebl->elf, NULL)) != NULL
>> - && ident[EI_OSABI] == ELFOSABI_LINUX)
>> - return "GNU_IFUNC";
>> + && (ident = elf_getident (ebl->elf, NULL)) != NULL)
>> + return "GNU_IFUNC"; /* Ignore EI_OSABI
>> + as STT_GNU_IFUNC is a reserved name. */
>
> Note that you technically also don't need the elf_getident call
> anymore, except as sanity check that the ELF header can be read
> properly.
>
> OK, with and without that change.
Sorry, I decided to scratch this as it violates the standard:
https://sourceware.org/bugzilla/show_bug.cgi?id=29718#c6
Cheers,
Martin
>
> Cheers,
>
> Mark
prev parent reply other threads:[~2022-11-25 13:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-24 12:23 Martin Liška
2022-11-24 12:33 ` Mark Wielaard
2022-11-25 13:06 ` Martin Liška [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=28991dcc-34eb-a6c5-b753-39c24933dded@suse.cz \
--to=mliska@suse.cz \
--cc=elfutils-devel@sourceware.org \
--cc=mark@klomp.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).