* [PATCH] tests: run-lfs-symbols.sh needs gawk
@ 2023-07-19 23:16 Sam James
2023-07-20 10:44 ` Mark Wielaard
0 siblings, 1 reply; 2+ messages in thread
From: Sam James @ 2023-07-19 23:16 UTC (permalink / raw)
To: elfutils-devel; +Cc: Sam James
With awk=mawk, I get:
```
FAIL: run-lfs-symbols.sh
========================
First sanity-check that LFS detection works.
checking ./testfile-nolfs
awk: line 3: syntax error at or near /
FAIL run-lfs-symbols.sh (exit status: 2)
```
* tests/run-lfs-symbols.sh: Call 'gawk' instead of 'awk'.
Signed-off-by: Sam James <sam@gentoo.org>
---
tests/run-lfs-symbols.sh | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/run-lfs-symbols.sh b/tests/run-lfs-symbols.sh
index 762a5d96..88c6270a 100755
--- a/tests/run-lfs-symbols.sh
+++ b/tests/run-lfs-symbols.sh
@@ -42,13 +42,13 @@ LFS_FORMAT='BEGIN {
LFS=$(printf "$LFS_FORMAT" "${abs_srcdir}/lfs-symbols")
makeprint() {
- make print-$1 -C $2 |& awk -F= "/^$1=/{ print \$2 }"
+ make print-$1 -C $2 |& gawk -F= "/^$1=/{ print \$2 }"
}
testrun_lfs() {
echo "checking $1"
if [ -e "$1" ]; then
- bad=$(testrun ${abs_top_builddir}/src/nm -u "$1" | awk "$LFS")
+ bad=$(testrun ${abs_top_builddir}/src/nm -u "$1" | gawk "$LFS")
if [ -n "$bad" ]; then
echo "$1 contains non-lfs symbols:" $bad
exit_status=1
--
2.41.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] tests: run-lfs-symbols.sh needs gawk
2023-07-19 23:16 [PATCH] tests: run-lfs-symbols.sh needs gawk Sam James
@ 2023-07-20 10:44 ` Mark Wielaard
0 siblings, 0 replies; 2+ messages in thread
From: Mark Wielaard @ 2023-07-20 10:44 UTC (permalink / raw)
To: Sam James, elfutils-devel
Hi Sam,
On Thu, 2023-07-20 at 00:16 +0100, Sam James via Elfutils-devel wrote:
> With awk=mawk, I get:
> ```
> FAIL: run-lfs-symbols.sh
> ========================
>
> First sanity-check that LFS detection works.
> checking ./testfile-nolfs
> awk: line 3: syntax error at or near /
> FAIL run-lfs-symbols.sh (exit status: 2)
> ```
>
> * tests/run-lfs-symbols.sh: Call 'gawk' instead of 'awk'.
Thanks. We already require gawk for known-dwarf.awk, check for it in
configure and use it for the coverage generation.
Pushed,
Mark
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-07-20 10:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-07-19 23:16 [PATCH] tests: run-lfs-symbols.sh needs gawk Sam James
2023-07-20 10:44 ` Mark Wielaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).