* [PATCH] tests: Don't redirect output to /dev/null in run-native-test.sh
@ 2023-12-12 9:49 Mark Wielaard
2023-12-18 12:34 ` Mark Wielaard
0 siblings, 1 reply; 2+ messages in thread
From: Mark Wielaard @ 2023-12-12 9:49 UTC (permalink / raw)
To: elfutils-devel; +Cc: David Abdurachmanov, Mark Wielaard
By redirecting all output to /dev/null in run-native-test.sh the
run-native-test.sh.log file will be empty on failures. This makes
it hard to figure out what went wrong.
* tests/run-native-test.sh: Remove /dev/null redirects.
Signed-off-by: Mark Wielaard <mark@klomp.org>
---
tests/run-native-test.sh | 15 +++++++++------
1 file changed, 9 insertions(+), 6 deletions(-)
diff --git a/tests/run-native-test.sh b/tests/run-native-test.sh
index 042a51c6..01a52e82 100755
--- a/tests/run-native-test.sh
+++ b/tests/run-native-test.sh
@@ -57,10 +57,10 @@ trap native_exit 0
for cc in "$HOSTCC" "$HOST_CC" cc gcc "$CC"; do
test "x$cc" != x || continue
- $cc -o native -g native.c > /dev/null 2>&1 &&
+ $cc -o native -g native.c &&
# Some shell versions don't do this right without the braces.
- { ./native > /dev/null 2>&1 & native=$! ; } &&
- sleep 1 && kill -0 $native 2> /dev/null &&
+ { ./native & native=$! ; } &&
+ sleep 1 && kill -0 $native &&
break ||
native=0
done
@@ -68,14 +68,17 @@ done
native_test()
{
# Try the build against itself, i.e. $config_host.
- testrun "$@" -e $1 > /dev/null
+ echo "Try the build against itself: $@ -e $1"
+ testrun "$@" -e $1
# Try the build against a presumed native process, running this sh.
# For tests requiring debug information, this may not test anything.
- testrun "$@" -p $$ > /dev/null
+ echo "Try the build against a presumed native process: $@ -p $$"
+ testrun "$@" -p $$
# Try the build against the trivial native program we just built with -g.
- test $native -eq 0 || testrun "$@" -p $native > /dev/null
+ echo "Try the build against the trivial native program: $@ -p $native"
+ test $native -eq 0 || testrun "$@" -p $native
}
native_test ${abs_builddir}/allregs
--
2.39.3
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] tests: Don't redirect output to /dev/null in run-native-test.sh
2023-12-12 9:49 [PATCH] tests: Don't redirect output to /dev/null in run-native-test.sh Mark Wielaard
@ 2023-12-18 12:34 ` Mark Wielaard
0 siblings, 0 replies; 2+ messages in thread
From: Mark Wielaard @ 2023-12-18 12:34 UTC (permalink / raw)
To: elfutils-devel; +Cc: David Abdurachmanov
On Tue, 2023-12-12 at 10:49 +0100, Mark Wielaard wrote:
> By redirecting all output to /dev/null in run-native-test.sh the
> run-native-test.sh.log file will be empty on failures. This makes
> it hard to figure out what went wrong.
>
> * tests/run-native-test.sh: Remove /dev/null redirects.
I pushed this.
Cheers,
Mark
P.S. There is now also a riscv builder.sourceware.org worker:
https://builder.sourceware.org/buildbot/#/workers/40
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-12-18 12:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-12-12 9:49 [PATCH] tests: Don't redirect output to /dev/null in run-native-test.sh Mark Wielaard
2023-12-18 12:34 ` Mark Wielaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).