public inbox for elfutils@sourceware.org
 help / color / mirror / Atom feed
From: Mark Wielaard <mark@klomp.org>
To: Adrian Ratiu <adrian.ratiu@collabora.com>, elfutils-devel@sourceware.org
Cc: manojgupta@chromium.org
Subject: Re: [PATCH v2] configure.ac: rework gnu99 ext check to allow clang
Date: Tue, 31 Aug 2021 13:38:01 +0200	[thread overview]
Message-ID: <3e385a62b34066da3152cf9746c02705f3d9736c.camel@klomp.org> (raw)
In-Reply-To: <20210830154313.2775441-1-adrian.ratiu@collabora.com>

Hi Adrian,

On Mon, 2021-08-30 at 18:43 +0300, Adrian Ratiu wrote:
> It is true that Clang does not support all gnu99 extensions [1],
> but not all of them are used in the codebase and over time there
> have been code cleanup efforts to improve Clang support.
> 
> For example after commit 779c57ea ("readelf: Pull advance_pc()
> in file scope") there are no more nested function declarations
> and elfutils now builds fine with Clang.
> 
> So in the interest of enabling Clang builds we remove the only
> remaining blocker: the configure checks for nested functions and
> variable length arrays which are also unused.
> 
> Considering mixed decls and code is also part of c99 standard,
> the entire check becomes redundant and we can just replace
> AC_PROG_CC -> AC_PROG_CC_C99.
> 
> [1] https://sourceware.org/bugzilla/show_bug.cgi?id=24964
> Signed-off-by: Adrian Ratiu <adrian.ratiu@collabora.com>

Thanks for reworking the patch. Pushed.

Thanks,

Mark

      reply	other threads:[~2021-08-31 11:38 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-30 15:43 Adrian Ratiu
2021-08-31 11:38 ` Mark Wielaard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3e385a62b34066da3152cf9746c02705f3d9736c.camel@klomp.org \
    --to=mark@klomp.org \
    --cc=adrian.ratiu@collabora.com \
    --cc=elfutils-devel@sourceware.org \
    --cc=manojgupta@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).