From: Mark Wielaard <mark@klomp.org>
To: luoyonggang@gmail.com
Cc: elfutils-devel@sourceware.org
Subject: Re: [PATCH 06/25] move platform depended include into system.h of libebl
Date: Tue, 20 Dec 2022 14:59:37 +0100 [thread overview]
Message-ID: <511175b206aad8d84b38aea5afbc558caf95e48d.camel@klomp.org> (raw)
In-Reply-To: <CAE2XoE9_3=NsWiOA40vdeXV49S5mc4EZMtJC0Vy1g8SojETVdQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 930 bytes --]
Hi,
On Sat, 2022-12-17 at 05:19 +0800, 罗勇刚(Yonggang Luo) wrote:
> On Fri, Oct 28, 2022 at 7:35 PM Mark Wielaard <mark@klomp.org> wrote:
> >
> > On Fri, 2022-10-21 at 02:25 +0800, Yonggang Luo via Elfutils-devel
> > wrote:
> > > Because all source in libebl #include <libeblP.h>, so #include
> > > <system.h> in
> > > libeblP.h is enough, there is multiple memory-access.h file, so
> > > use
> > > relative path to
> > > include it properly,
> >
> > I am not a fan of the relative path trick, especially if there it
> > is
> > clear only one is every needed. You also use it for other files,
> > why?
>
> I am respect the original code
> looks at
> https://github.com/sourceware-org/elfutils/blob/master/libdwfl/core-file.c#L31
I see. But I rather fix that than do the same in new files.
The attached patch does that so no relative paths are needed in
#include statements.
Cheers,
Mark
[-- Attachment #2: 0001-Do-not-use-relative-include-paths-in-library-files.patch --]
[-- Type: text/x-patch, Size: 15435 bytes --]
From 426db34b65d660c439b31d25308bc346d6272923 Mon Sep 17 00:00:00 2001
From: Mark Wielaard <mark@klomp.org>
Date: Tue, 20 Dec 2022 14:53:43 +0100
Subject: [PATCH] Do not use relative include paths in library files.
Rely on include dirs being set up correctly. Setup libdw AM_CPPFLAGS
to include libebl directory. In libdwfl note that debuginfod.h is a
generated file in the builddir. Only include it in the one file
debuginfod-client.c that really needs it.
Signed-off-by: Mark Wielaard <mark@klomp.org>
---
libasm/ChangeLog | 6 ++++++
libasm/disasm_begin.c | 2 +-
libasm/disasm_cb.c | 2 +-
libcpu/ChangeLog | 6 ++++++
libcpu/bpf_disasm.c | 4 ++--
libcpu/i386_disasm.c | 2 +-
libcpu/riscv_disasm.c | 2 +-
libdw/ChangeLog | 7 +++++++
libdw/Makefile.am | 2 +-
libdw/cfi.c | 2 +-
libdw/encoded-value.h | 2 +-
libdw/frame-cache.c | 2 +-
libdwelf/ChangeLog | 4 ++++
libdwelf/libdwelfP.h | 2 +-
libdwfl/ChangeLog | 24 ++++++++++++++++++++++++
libdwfl/Makefile.am | 2 +-
libdwfl/core-file.c | 2 +-
libdwfl/cu.c | 4 ++--
libdwfl/debuginfod-client.c | 2 ++
libdwfl/dwfl_dwarf_line.c | 2 +-
libdwfl/dwfl_lineinfo.c | 2 +-
libdwfl/dwfl_module.c | 2 +-
libdwfl/dwfl_module_dwarf_cfi.c | 2 +-
libdwfl/dwfl_module_eh_cfi.c | 2 +-
libdwfl/dwfl_module_getdwarf.c | 4 ++--
libdwfl/dwfl_module_getsrc.c | 2 +-
libdwfl/dwfl_module_getsrc_file.c | 2 +-
libdwfl/dwfl_segment_report_module.c | 2 +-
libdwfl/elf-from-memory.c | 2 +-
libdwfl/frame_unwind.c | 2 +-
libdwfl/libdwflP.h | 8 ++------
libdwfl/lines.c | 2 +-
libdwfl/link_map.c | 2 +-
libdwfl/linux-core-attach.c | 2 +-
libdwfl/open.c | 2 +-
35 files changed, 82 insertions(+), 37 deletions(-)
diff --git a/libasm/ChangeLog b/libasm/ChangeLog
index ce0f24f4..a12d14b3 100644
--- a/libasm/ChangeLog
+++ b/libasm/ChangeLog
@@ -1,3 +1,9 @@
+2022-12-20 Mark Wielaard <mark@klomp.org>
+
+ * disasm_begin.c: Include libeblP.h.
+ * disasm_cb.c: Likewise.
+ * bpf_disasm.c: Likewise and include common.h.
+
2022-10-21 Yonggang Luo <luoyonggang@gmail.com>
* asm_abort.c: Don't include unistd.h.
diff --git a/libasm/disasm_begin.c b/libasm/disasm_begin.c
index cb10f66e..78db90c7 100644
--- a/libasm/disasm_begin.c
+++ b/libasm/disasm_begin.c
@@ -34,7 +34,7 @@
#include <stdlib.h>
#include "libasmP.h"
-#include "../libebl/libeblP.h"
+#include "libeblP.h"
DisasmCtx_t *
diff --git a/libasm/disasm_cb.c b/libasm/disasm_cb.c
index 80f8b25b..9353e2e5 100644
--- a/libasm/disasm_cb.c
+++ b/libasm/disasm_cb.c
@@ -33,7 +33,7 @@
#include <string.h>
#include "libasmP.h"
-#include "../libebl/libeblP.h"
+#include "libeblP.h"
struct symtoken
diff --git a/libcpu/ChangeLog b/libcpu/ChangeLog
index 248b1aba..bd517b94 100644
--- a/libcpu/ChangeLog
+++ b/libcpu/ChangeLog
@@ -1,3 +1,9 @@
+2022-12-20 Mark Wielaard <mark@klomp.org>
+
+ * bpf_disasm.c: Include common.h and libeblP.h.
+ * i386_disasm.c: Include libeblP.h.
+ * riscv_disasm.c: Likewise.
+
2022-10-21 Yonggang Luo <luoyonggang@gmail.com>
* i386_data.h: Define FCT_mod$64r_m as FCT_mod$r_m for i386.
diff --git a/libcpu/bpf_disasm.c b/libcpu/bpf_disasm.c
index 62643c81..dabd8a4e 100644
--- a/libcpu/bpf_disasm.c
+++ b/libcpu/bpf_disasm.c
@@ -37,8 +37,8 @@
#include <inttypes.h>
#include "bpf.h"
-#include "../libelf/common.h"
-#include "../libebl/libeblP.h"
+#include "common.h"
+#include "libeblP.h"
static const char class_string[8][8] = {
[BPF_LD] = "ld",
diff --git a/libcpu/i386_disasm.c b/libcpu/i386_disasm.c
index 599d1654..c42f8d1c 100644
--- a/libcpu/i386_disasm.c
+++ b/libcpu/i386_disasm.c
@@ -41,7 +41,7 @@
#include <stdlib.h>
#include <string.h>
-#include "../libebl/libeblP.h"
+#include "libeblP.h"
#define MACHINE_ENCODING LITTLE_ENDIAN
#include "memory-access.h"
diff --git a/libcpu/riscv_disasm.c b/libcpu/riscv_disasm.c
index 7175c077..823fe9ca 100644
--- a/libcpu/riscv_disasm.c
+++ b/libcpu/riscv_disasm.c
@@ -39,7 +39,7 @@
#include <stdlib.h>
#include <string.h>
-#include "../libebl/libeblP.h"
+#include "libeblP.h"
#define MACHINE_ENCODING LITTLE_ENDIAN
#include "memory-access.h"
diff --git a/libdw/ChangeLog b/libdw/ChangeLog
index 019c6580..4c7af94e 100644
--- a/libdw/ChangeLog
+++ b/libdw/ChangeLog
@@ -1,3 +1,10 @@
+2022-12-20 Mark Wielaard <mark@klomp.org>
+
+ * Makefile.am (AM_CPPFLAGS): Add -I$(srcdir)/../libebl.
+ * cfi.c: Include libebl.h.
+ * encoded-value.h: Likewise.
+ * frame-cache.h: Likewise.
+
2022-10-21 Yonggang Luo <luoyonggang@gmail.com>
* memory-access.h (get_uleb128_step): Use __typeof.
diff --git a/libdw/Makefile.am b/libdw/Makefile.am
index 4fda33bd..1b6fead4 100644
--- a/libdw/Makefile.am
+++ b/libdw/Makefile.am
@@ -31,7 +31,7 @@ include $(top_srcdir)/config/eu.am
if BUILD_STATIC
AM_CFLAGS += $(fpic_CFLAGS)
endif
-AM_CPPFLAGS += -I$(srcdir)/../libelf -I$(srcdir)/../libdwelf -pthread
+AM_CPPFLAGS += -I$(srcdir)/../libebl -I$(srcdir)/../libelf -I$(srcdir)/../libdwelf -pthread
VERSION = 1
lib_LIBRARIES = libdw.a
diff --git a/libdw/cfi.c b/libdw/cfi.c
index a73fb03f..6d08ca90 100644
--- a/libdw/cfi.c
+++ b/libdw/cfi.c
@@ -31,7 +31,7 @@
#endif
#include <dwarf.h>
-#include "../libebl/libebl.h"
+#include "libebl.h"
#include "cfi.h"
#include "memory-access.h"
#include "encoded-value.h"
diff --git a/libdw/encoded-value.h b/libdw/encoded-value.h
index f0df4cec..d4e01924 100644
--- a/libdw/encoded-value.h
+++ b/libdw/encoded-value.h
@@ -32,7 +32,7 @@
#include <dwarf.h>
#include <stdlib.h>
#include "libdwP.h"
-#include "../libelf/common.h"
+#include "common.h"
/* Returns zero if the value is omitted, the encoding is unknown or
diff --git a/libdw/frame-cache.c b/libdw/frame-cache.c
index 5b6afb5d..683f7f17 100644
--- a/libdw/frame-cache.c
+++ b/libdw/frame-cache.c
@@ -30,7 +30,7 @@
# include <config.h>
#endif
-#include "../libebl/libebl.h"
+#include "libebl.h"
#include "cfi.h"
#include <search.h>
#include <stdlib.h>
diff --git a/libdwelf/ChangeLog b/libdwelf/ChangeLog
index 5d61aa85..1940629f 100644
--- a/libdwelf/ChangeLog
+++ b/libdwelf/ChangeLog
@@ -1,3 +1,7 @@
+2022-12-20 Mark Wielaard <mark@klomp.org>
+
+ * libdwelfP.h: Include libdwP.h.
+
2022-10-21 Yonggang Luo <luoyonggang@gmail.com>
* dwelf_elf_begin.c: Don't include unistd.h.
diff --git a/libdwelf/libdwelfP.h b/libdwelf/libdwelfP.h
index d83c759a..faaf1a20 100644
--- a/libdwelf/libdwelfP.h
+++ b/libdwelf/libdwelfP.h
@@ -30,7 +30,7 @@
#define _LIBDWELFP_H 1
#include <libdwelf.h>
-#include "../libdw/libdwP.h" /* We need its INTDECLs. */
+#include "libdwP.h" /* We need its INTDECLs. */
#include <assert.h>
#include <string.h>
diff --git a/libdwfl/ChangeLog b/libdwfl/ChangeLog
index 68527327..1b465e48 100644
--- a/libdwfl/ChangeLog
+++ b/libdwfl/ChangeLog
@@ -1,3 +1,27 @@
+2022-12-20 Mark Wielaard <mark@klomp.org>
+
+ * Makefile.am (AM_CPPFLAGS): debuginfod.h is in builddir.
+ * core-file.c: Include libelfP.h.
+ * cu.c: Include libdwP.h and memory-access.h.
+ * debuginfod-client.c: Include debuginfod.h.
+ * dwfl_dwarf_line.c: Include libdwP.h.
+ * dwfl_lineinfo.c: Include libdwP.h.
+ * dwfl_module.c: Include cfi.h.
+ * dwfl_module_dwarf_cfi.c: Include cfi.h.
+ * dwfl_module_eh_cfi.c: Include cfi.h.
+ * dwfl_module_getdwarf.c: Include libdwP.h and libelfP.h.
+ * dwfl_module_getsrc.c: Include libdwP.h.
+ * dwfl_module_getsrc_file.c: Include libdwP.h.
+ * dwfl_segment_report_module.c: Include libelfP.h.
+ * elf-from-memory.c: Include libelfP.h.
+ * frame_unwind.c: Include dwarf.h.
+ * libdwflP.h: Include libdwP.h and libdwelfP.h. Don't include
+ debuginfod.h.
+ * lines.c: Include libdwP.h.
+ * link_map.c: Include memory-access.h.
+ * linux-core-attach.c: Include memory-access.h.
+ * open.c: Include libelfP.h.
+
2022-11-28 Gavin Li <gavin@matician.com>
Mark Wielaard <mark@klomp.org>
diff --git a/libdwfl/Makefile.am b/libdwfl/Makefile.am
index 3278358d..6b26cd51 100644
--- a/libdwfl/Makefile.am
+++ b/libdwfl/Makefile.am
@@ -31,7 +31,7 @@
##
include $(top_srcdir)/config/eu.am
AM_CPPFLAGS += -I$(srcdir) -I$(srcdir)/../libelf -I$(srcdir)/../libebl \
- -I$(srcdir)/../libdw -I$(srcdir)/../libdwelf -I$(srcdir)/../debuginfod
+ -I$(srcdir)/../libdw -I$(srcdir)/../libdwelf -I$(builddir)/../debuginfod
VERSION = 1
noinst_LIBRARIES = libdwfl.a
diff --git a/libdwfl/core-file.c b/libdwfl/core-file.c
index cd9b4f38..1ddf0f18 100644
--- a/libdwfl/core-file.c
+++ b/libdwfl/core-file.c
@@ -28,7 +28,7 @@
not, see <http://www.gnu.org/licenses/>. */
#include <config.h>
-#include "../libelf/libelfP.h" /* For NOTE_ALIGN. */
+#include "libelfP.h" /* For NOTE_ALIGN. */
#undef _
#include "libdwflP.h"
#include <gelf.h>
diff --git a/libdwfl/cu.c b/libdwfl/cu.c
index 4de66248..b1afb19a 100644
--- a/libdwfl/cu.c
+++ b/libdwfl/cu.c
@@ -31,8 +31,8 @@
#endif
#include "libdwflP.h"
-#include "../libdw/libdwP.h"
-#include "../libdw/memory-access.h"
+#include "libdwP.h"
+#include "memory-access.h"
#include <search.h>
diff --git a/libdwfl/debuginfod-client.c b/libdwfl/debuginfod-client.c
index d581daab..882a5eff 100644
--- a/libdwfl/debuginfod-client.c
+++ b/libdwfl/debuginfod-client.c
@@ -35,6 +35,8 @@
#ifdef ENABLE_LIBDEBUGINFOD
+#include "debuginfod.h"
+
#include <pthread.h>
#include <dlfcn.h>
diff --git a/libdwfl/dwfl_dwarf_line.c b/libdwfl/dwfl_dwarf_line.c
index e22e984c..5084c659 100644
--- a/libdwfl/dwfl_dwarf_line.c
+++ b/libdwfl/dwfl_dwarf_line.c
@@ -31,7 +31,7 @@
#endif
#include "libdwflP.h"
-#include "../libdw/libdwP.h"
+#include "libdwP.h"
Dwarf_Line *
dwfl_dwarf_line (Dwfl_Line *line, Dwarf_Addr *bias)
diff --git a/libdwfl/dwfl_lineinfo.c b/libdwfl/dwfl_lineinfo.c
index 96187128..85c4b314 100644
--- a/libdwfl/dwfl_lineinfo.c
+++ b/libdwfl/dwfl_lineinfo.c
@@ -31,7 +31,7 @@
#endif
#include "libdwflP.h"
-#include "../libdw/libdwP.h"
+#include "libdwP.h"
const char *
dwfl_lineinfo (Dwfl_Line *line, Dwarf_Addr *addr, int *linep, int *colp,
diff --git a/libdwfl/dwfl_module.c b/libdwfl/dwfl_module.c
index 4fbff33e..221d726d 100644
--- a/libdwfl/dwfl_module.c
+++ b/libdwfl/dwfl_module.c
@@ -31,7 +31,7 @@
#endif
#include "libdwflP.h"
-#include "../libdw/cfi.h"
+#include "cfi.h"
#include <search.h>
static void
diff --git a/libdwfl/dwfl_module_dwarf_cfi.c b/libdwfl/dwfl_module_dwarf_cfi.c
index 0e5b4356..05a14f7c 100644
--- a/libdwfl/dwfl_module_dwarf_cfi.c
+++ b/libdwfl/dwfl_module_dwarf_cfi.c
@@ -31,7 +31,7 @@
#endif
#include "libdwflP.h"
-#include "../libdw/cfi.h"
+#include "cfi.h"
Dwarf_CFI *
internal_function
diff --git a/libdwfl/dwfl_module_eh_cfi.c b/libdwfl/dwfl_module_eh_cfi.c
index c296e399..aac6657d 100644
--- a/libdwfl/dwfl_module_eh_cfi.c
+++ b/libdwfl/dwfl_module_eh_cfi.c
@@ -31,7 +31,7 @@
#endif
#include "libdwflP.h"
-#include "../libdw/cfi.h"
+#include "cfi.h"
Dwarf_CFI *
dwfl_module_eh_cfi (Dwfl_Module *mod, Dwarf_Addr *bias)
diff --git a/libdwfl/dwfl_module_getdwarf.c b/libdwfl/dwfl_module_getdwarf.c
index 498c7cd2..9ba499bb 100644
--- a/libdwfl/dwfl_module_getdwarf.c
+++ b/libdwfl/dwfl_module_getdwarf.c
@@ -34,8 +34,8 @@
#include <inttypes.h>
#include <fcntl.h>
#include <string.h>
-#include "../libdw/libdwP.h" /* DWARF_E_* values are here. */
-#include "../libelf/libelfP.h"
+#include "libdwP.h" /* DWARF_E_* values are here. */
+#include "libelfP.h"
#include "system.h"
static inline Dwfl_Error
diff --git a/libdwfl/dwfl_module_getsrc.c b/libdwfl/dwfl_module_getsrc.c
index fc99b163..73dbf435 100644
--- a/libdwfl/dwfl_module_getsrc.c
+++ b/libdwfl/dwfl_module_getsrc.c
@@ -31,7 +31,7 @@
#endif
#include "libdwflP.h"
-#include "../libdw/libdwP.h"
+#include "libdwP.h"
Dwfl_Line *
dwfl_module_getsrc (Dwfl_Module *mod, Dwarf_Addr addr)
diff --git a/libdwfl/dwfl_module_getsrc_file.c b/libdwfl/dwfl_module_getsrc_file.c
index cea2ba41..513af6b8 100644
--- a/libdwfl/dwfl_module_getsrc_file.c
+++ b/libdwfl/dwfl_module_getsrc_file.c
@@ -31,7 +31,7 @@
#endif
#include "libdwflP.h"
-#include "../libdw/libdwP.h"
+#include "libdwP.h"
static inline const char *
diff --git a/libdwfl/dwfl_segment_report_module.c b/libdwfl/dwfl_segment_report_module.c
index 19fa6ded..41285103 100644
--- a/libdwfl/dwfl_segment_report_module.c
+++ b/libdwfl/dwfl_segment_report_module.c
@@ -28,7 +28,7 @@
not, see <http://www.gnu.org/licenses/>. */
#include <config.h>
-#include "../libelf/libelfP.h" /* For NOTE_ALIGN4 and NOTE_ALIGN8. */
+#include "libelfP.h" /* For NOTE_ALIGN4 and NOTE_ALIGN8. */
#undef _
#include "libdwflP.h"
#include "common.h"
diff --git a/libdwfl/elf-from-memory.c b/libdwfl/elf-from-memory.c
index a0ef0014..f7fb3ab7 100644
--- a/libdwfl/elf-from-memory.c
+++ b/libdwfl/elf-from-memory.c
@@ -27,7 +27,7 @@
not, see <http://www.gnu.org/licenses/>. */
#include <config.h>
-#include "../libelf/libelfP.h"
+#include "libelfP.h"
#undef _
#include "libdwflP.h"
diff --git a/libdwfl/frame_unwind.c b/libdwfl/frame_unwind.c
index 8185d84b..1e2f0255 100644
--- a/libdwfl/frame_unwind.c
+++ b/libdwfl/frame_unwind.c
@@ -33,7 +33,7 @@
#include "cfi.h"
#include <stdlib.h>
#include "libdwflP.h"
-#include "../libdw/dwarf.h"
+#include "dwarf.h"
#include <system.h>
/* Maximum number of DWARF expression stack slots before returning an error. */
diff --git a/libdwfl/libdwflP.h b/libdwfl/libdwflP.h
index 011b5de9..cdc528d0 100644
--- a/libdwfl/libdwflP.h
+++ b/libdwfl/libdwflP.h
@@ -38,12 +38,8 @@
#include <stdlib.h>
#include <string.h>
-#include "../libdw/libdwP.h" /* We need its INTDECLs. */
-#include "../libdwelf/libdwelfP.h"
-
-#ifdef ENABLE_LIBDEBUGINFOD
-#include "../debuginfod/debuginfod.h"
-#endif
+#include "libdwP.h" /* We need its INTDECLs. */
+#include "libdwelfP.h"
typedef struct Dwfl_Process Dwfl_Process;
diff --git a/libdwfl/lines.c b/libdwfl/lines.c
index 128c0c97..a7f3004a 100644
--- a/libdwfl/lines.c
+++ b/libdwfl/lines.c
@@ -31,7 +31,7 @@
#endif
#include "libdwflP.h"
-#include "../libdw/libdwP.h"
+#include "libdwP.h"
Dwfl_Error
internal_function
diff --git a/libdwfl/link_map.c b/libdwfl/link_map.c
index 7ec7eca1..06d85eb6 100644
--- a/libdwfl/link_map.c
+++ b/libdwfl/link_map.c
@@ -29,7 +29,7 @@
#include <config.h>
#include "libdwflP.h"
-#include "../libdw/memory-access.h"
+#include "memory-access.h"
#include "system.h"
#include <fcntl.h>
diff --git a/libdwfl/linux-core-attach.c b/libdwfl/linux-core-attach.c
index ee7afa40..d6f9e971 100644
--- a/libdwfl/linux-core-attach.c
+++ b/libdwfl/linux-core-attach.c
@@ -34,7 +34,7 @@
#include <fcntl.h>
#include "system.h"
-#include "../libdw/memory-access.h"
+#include "memory-access.h"
struct core_arg
{
diff --git a/libdwfl/open.c b/libdwfl/open.c
index 68b755cd..32bd7ff8 100644
--- a/libdwfl/open.c
+++ b/libdwfl/open.c
@@ -31,7 +31,7 @@
# include <config.h>
#endif
-#include "../libelf/libelfP.h"
+#include "libelfP.h"
#undef _
#include "libdwflP.h"
--
2.18.4
next prev parent reply other threads:[~2022-12-20 13:59 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-20 18:25 [PATCH 00/25] Patches for building with mingw/gcc msvc/clang-cl Yonggang Luo
2022-10-20 18:25 ` [PATCH 01/25] Rename 'hello2.spec.' -> 'hello2.spec' 'hello3.spec.' -> 'hello3.spec' Yonggang Luo
2022-10-27 13:02 ` Mark Wielaard
2022-10-20 18:25 ` [PATCH 02/25] ignore build directory Yonggang Luo
2022-10-27 13:03 ` Mark Wielaard
2022-12-16 21:14 ` 罗勇刚(Yonggang Luo)
2022-12-20 12:35 ` Mark Wielaard
2022-10-20 18:25 ` [PATCH 03/25] libebl: There is no need #include <dlfcn.h> in eblclosebackend.c and eblopenbackend.c Yonggang Luo
2022-10-27 13:09 ` Mark Wielaard
2022-10-20 18:25 ` [PATCH 04/25] libelf/libdwfl: Remove "#define LIB_SYSTEM_H 1" in libelf_crc32.c and libdwfl_crc32.c Yonggang Luo
2022-10-27 13:20 ` Mark Wielaard
2022-10-20 18:25 ` [PATCH 05/25] use #include <system.h> instead platform depended header <endian.h> in libdw/memory-access.h Yonggang Luo
2022-10-27 13:26 ` Mark Wielaard
2022-10-20 18:25 ` [PATCH 06/25] move platform depended include into system.h of libebl Yonggang Luo
2022-10-28 11:35 ` Mark Wielaard
2022-12-16 21:19 ` 罗勇刚(Yonggang Luo)
2022-12-20 13:59 ` Mark Wielaard [this message]
2022-12-20 17:44 ` Mark Wielaard
2022-10-20 18:25 ` [PATCH 07/25] move platform depended include into system.h of libasm, libcpu, libdw, libdwfl and libdwelf Yonggang Luo
2022-10-28 12:07 ` Mark Wielaard
2022-10-20 18:25 ` [PATCH 08/25] Use configure to detect HAVE_DECL_MMAP and use it for system doesn't provide sys/mman.h Yonggang Luo
2022-10-28 11:41 ` Mark Wielaard
2022-12-16 21:21 ` 罗勇刚(Yonggang Luo)
2022-12-20 14:04 ` Mark Wielaard
2022-12-20 16:30 ` 罗勇刚(Yonggang Luo)
2022-12-21 16:54 ` Mark Wielaard
2022-12-22 3:50 ` 罗勇刚(Yonggang Luo)
2022-10-20 18:25 ` [PATCH 09/25] include libgen.h in system.h Yonggang Luo
2022-10-28 11:45 ` Mark Wielaard
2022-12-16 21:22 ` 罗勇刚(Yonggang Luo)
2022-12-16 21:34 ` 罗勇刚(Yonggang Luo)
2022-12-20 15:05 ` Mark Wielaard
2022-10-20 18:25 ` [PATCH 10/25] libcpu: Remove the need of NMNES by using enum Yonggang Luo
2022-12-12 12:37 ` Mark Wielaard
2022-10-20 18:25 ` [PATCH 11/25] libcpu: Use __asm instead asm that can be recognized by both clang-cl and gcc Yonggang Luo
2022-12-12 12:42 ` Mark Wielaard
2022-12-16 21:36 ` 罗勇刚(Yonggang Luo)
2022-10-20 18:25 ` [PATCH 12/25] libcpu: Use "#define FCT_mod$64r_m FCT_mod$r_m" is enough and can be recognized by clang-cl on windows in i386_data.h Yonggang Luo
2022-12-12 12:58 ` Mark Wielaard
2022-10-20 18:25 ` [PATCH 13/25] libdw: typeof -> __typeof that can be recognized by both clang-cl and gcc Yonggang Luo
2022-12-12 13:12 ` Mark Wielaard
2022-10-20 18:25 ` [PATCH 14/25] libdw: check __OPTIMIZE__ in dwarf_whatattr.c and dwarf_whatform.c to match the header Yonggang Luo
2022-12-12 13:31 ` Mark Wielaard
2022-12-16 21:47 ` 罗勇刚(Yonggang Luo)
2022-12-20 15:08 ` Mark Wielaard
2022-12-20 16:31 ` 罗勇刚(Yonggang Luo)
2022-10-20 18:25 ` [PATCH 15/25] lib: Implement error properly even when not HAVE_ERR_H Yonggang Luo
2022-12-12 15:37 ` Mark Wielaard
2022-12-16 21:50 ` 罗勇刚(Yonggang Luo)
2022-12-20 15:10 ` Mark Wielaard
2022-10-20 18:25 ` [PATCH 16/25] libeu: Move the implementation of pwrite_retry, write_retry and pread_retry from header to source Yonggang Luo
2022-12-12 15:45 ` Mark Wielaard
2022-10-20 18:25 ` [PATCH 17/25] libelf: uid_t, gid_t and mode_t are not comes with msvcrt, so using long/unsigned long instead on win32 Yonggang Luo
2022-10-20 18:25 ` [PATCH 18/25] lib: Use NOT_HAVE_LIBINTL to guard #include <libintl.h> Yonggang Luo
2022-10-20 18:25 ` [PATCH 19/25] libelf: F_GETFD may not predefined with msvc/mingw, guard the usage of it Yonggang Luo
2022-12-12 15:54 ` Mark Wielaard
2022-10-20 18:25 ` [PATCH 20/25] Add function sys_get_page_size to replace platform dependent sysconf (_SC_PAGESIZE) Yonggang Luo
2022-10-20 18:26 ` [PATCH 21/25] libasm: stdio_ext.h are not present on win32 Yonggang Luo
2022-10-20 18:26 ` [PATCH 22/25] libebl/libdwelf: define ssize_t and pid_t for MSVC within installed header libdwelf.h and libebl.h Yonggang Luo
2022-10-20 18:26 ` [PATCH 23/25] libasm/debuginfod: fchmod doesn't present on win32 Yonggang Luo
2022-10-20 18:26 ` [PATCH 24/25] lib: isatty is not available on windows Yonggang Luo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=511175b206aad8d84b38aea5afbc558caf95e48d.camel@klomp.org \
--to=mark@klomp.org \
--cc=elfutils-devel@sourceware.org \
--cc=luoyonggang@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).