From: Mark Wielaard <mark@klomp.org>
To: Noah Sanci <nsanci@redhat.com>, elfutils-devel@sourceware.org
Subject: Re: debuginfod: Fracture tests/run-debuginfod-find.sh into specific tests
Date: Thu, 02 Sep 2021 13:29:23 +0200 [thread overview]
Message-ID: <67cbd2e7bbe3e354bc004684749a4e41ab0026c4.camel@klomp.org> (raw)
In-Reply-To: <CAJXA7qiJ90=ir4NvuZ1rrRy5GU8xY+sSzQ7ywK6G2pg35wYwDQ@mail.gmail.com>
Hi Noah,
I am excited about this patch, but wondering about this part:
> diff --git a/ChangeLog b/ChangeLog
> index 12b8f403..0aeac175 100644
> --- a/ChangeLog
> +++ b/ChangeLog
> @@ -1,3 +1,6 @@
> +2021-08-23 Noah Sanci <nsanci@redhat.com
> + * ChangeLog: removed --sign flag on rpmbuild
> +
> 2021-07-28 Mark Wielaard <mark@klomp.org>
>
> * configure.ac (AC_CHECK_DECLS): Add reallocarray check.
> diff --git a/Makefile.am b/Makefile.am
> index 9c47afa9..3dfefa9f 100644
> --- a/Makefile.am
> +++ b/Makefile.am
> @@ -45,7 +45,7 @@ distcheck-hook:
> chmod -R u+w $(distdir)
>
> rpm: dist
> - rpmbuild -ts --sign elfutils-@PACKAGE_VERSION@.tar.bz2
> + rpmbuild -ts elfutils-@PACKAGE_VERSION@.tar.bz2
>
> if GCOV
This might be a ok thing to do. I am not sure who is actually using the
rpm target (we release src.tar.bz files, not srpms). But it seems
unrelated to the rest of the patch.
Cheers,
Mark
next prev parent reply other threads:[~2021-09-02 11:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-23 14:01 Noah Sanci
2021-08-23 19:31 ` Noah Sanci
2021-09-02 11:29 ` Mark Wielaard [this message]
2021-09-02 13:42 ` Mark Wielaard
2021-09-02 18:59 ` Noah Sanci
2021-09-03 8:45 ` Mark Wielaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=67cbd2e7bbe3e354bc004684749a4e41ab0026c4.camel@klomp.org \
--to=mark@klomp.org \
--cc=elfutils-devel@sourceware.org \
--cc=nsanci@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).