From: Florian Weimer <fw@deneb.enyo.de>
To: Ulf Hermann <ulf.hermann@qt.io>
Cc: elfutils-devel@sourceware.org
Subject: Re: [PATCH] Add replacement endian.h and byteswap.h to libgnu
Date: Thu, 16 Nov 2017 09:21:00 -0000 [thread overview]
Message-ID: <87fu9e1suy.fsf@mid.deneb.enyo.de> (raw)
In-Reply-To: <021350f6-78df-9a10-cf36-b06ad119647e@qt.io> (Ulf Hermann's message of "Thu, 16 Nov 2017 09:54:16 +0100")
* Ulf Hermann:
>>> Some systems don't provide endian.h and byteswap.h. The required
>>> functions are trivial to define using sys/param.h and gcc builtins,
>>> though.
>>>
>>> Also, include endian.h in dwelf_scn_gnu_compressed_size.c as that uses
>>> be64toh().
>>
>> This is still an issue with non-glibc, non-BSD compilation. The patch
>> is not ideal, as it depends on a GCC extension, but it's an
>> improvement for those who use GCC on a platform which does not provide
>> these functions as part of the C library.
>
> Well, there are a lot of other issues to be fixed if you want to build
> elfutils on anything non-gcc. We could add a further check for those
> builtins and sys/param.h and then add a somewhat less trivial version
> of endian.h and byteswap.h if they are missing. But that would likely
> involve other compiler extensions or OS-specific headers.
Ah, fair enough. I mainly wanted to increase awareness of the patch
because it has not been merged yet.
next prev parent reply other threads:[~2017-11-16 9:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-04 8:20 Ulf Hermann
2017-11-16 8:24 ` Florian Weimer
2017-11-16 8:54 ` Ulf Hermann
2017-11-16 9:21 ` Florian Weimer [this message]
2017-11-16 13:12 ` Mark Wielaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fu9e1suy.fsf@mid.deneb.enyo.de \
--to=fw@deneb.enyo.de \
--cc=elfutils-devel@sourceware.org \
--cc=ulf.hermann@qt.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).