Re: [PATCH] lib: avoid potential problems with `-fno-common`

[Mark Wielaard <mark@klomp.org>]

Hi Saleem,

On Fri, 2021-08-27 at 15:51 +0000, Saleem Abdulrasool via Elfutils-devel wrote:
> This properly homes the fallback function into a translation unit rather
> than trying to define an inline common definition for the fallback path.
> The intent of the original approach was to actually simply avoid adding
> a new source file that is used for the fallback path.  However, that may
> cause trouble with multiple definitions if the symbol does not get vague
> linkage (which itself is not particularly great).  This simplifies the
> behaviour at the cost of an extra inode.

I applied this, but messed up, sorry.
I somehow dropped the lib/error.c file from the commit.

When the buildbot yells and screams about a broken build that wasn't
your fault. I pushed a followup commit to fix it:

commit 610623458b7e98ed3e912e4b7ca8050f6ce4c698 (HEAD -> master)
Author: Mark Wielaard <mark@klomp.org>
Date:   Fri Aug 27 18:47:30 2021 +0200

    Add lib/error.c
    
    This new file was supposed to be part of 4d6dd0e5a "lib: avoid potential
    problems with `-fno-common`".
    
    Signed-off-by: Mark Wielaard <mark@klomp.org>

Apologies,

Mark